chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java - Issue 2862493002: [Android WebAPKs] Add UMA metric for ShellAPK version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

Issue 2862493002: [Android WebAPKs] Add UMA metric for ShellAPK version (Closed)

Patch Set: Merge branch 'master' into metric Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

index a3843dd67433afd96b26248ca9db269c4703a2c8..3d18c424522451143068f8e75823ef7e7afa26fa 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

@@ -134,9 +134,11 @@ public class WebApkActivity extends WebappActivity {

protected void onDeferredStartupWithStorage(WebappDataStorage storage) {

super.onDeferredStartupWithStorage(storage);

+ WebApkInfo info = (WebApkInfo) mWebappInfo;

+ WebApkUma.recordShellApkVersion(info.shellApkVersion(), info.webApkPackageName());

mUpdateManager = new WebApkUpdateManager(WebApkActivity.this, storage);

- mUpdateManager.updateIfNeeded(getActivityTab(),

- (WebApkInfo) mWebappInfo);

+ mUpdateManager.updateIfNeeded(getActivityTab(), info);

}

@Override