Add metrics for certificate report uploads

chrome/browser/safe_browsing/certificate_reporting_service.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_CERTIFICATE_REPORTING_SERVICE_H_
 #define CHROME_BROWSER_SAFE_BROWSING_CERTIFICATE_REPORTING_SERVICE_H_
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 37 matching lines @@
 // available at all times, and it should know when SafeBrowsing shuts down. It
 // does this by subscribing to SafeBrowsingService shut downs when it's
 // created. When SafeBrowsingService shuts down, CertificateReportingService
 // also shuts down.
 //
 // This class also observes SafeBrowsing preference changes to enable/disable
 // reporting. It does this by subscribing to changes in SafeBrowsing and
 // extended reporting preferences.
 class CertificateReportingService : public KeyedService {
  public:
+  // Events for UMA. Do not rename or remove values, add new values to the end.
+  // Public for testing.
+  enum UMAEvent {

[Jialiu Lin, 2017/05/05 00:25:43]

nit: how about "ReportOutcome"?  "UMAEvent" sounds a little bit too general.

[estark, 2017/05/05 16:21:13]

+1

[meacer, 2017/05/05 19:24:19]

Done.

+    // A report is submitted. This includes failed and successful uploads as
+    // well as uploads that never return a response.
+    REPORT_SUBMITTED,

[estark, 2017/05/05 16:21:13]

Not sure but I think you're supposed to explicitly index (i.e. add " = 0" here)

[meacer, 2017/05/05 19:24:19]

Done.

+    // A report submission failed.
+    REPORT_FAILED,
+    // A report submission was successful.

[estark, 2017/05/05 16:21:13]

nit: perhaps define successful (HTTP 200 status code?)

[meacer, 2017/05/05 19:24:19]

Done.

+    REPORT_SUCCESSFUL,
+    // A report was dropped from the reporting queue because it was older
+    // than report TTL, or it was ignored because the queue was full and the
+    // report was older than the oldest report in the queue. Does not include
+    // reports that were cleared because of a SafeBrowsing preference change.
+    REPORT_DROPPED_OR_IGNORED,
+    REPORT_EVENT_COUNT
+  };
+
   // Represents a report to be sent.
   struct Report {
     int report_id;
     base::Time creation_time;
     std::string serialized_report;
     bool is_retried;
     Report(int report_id,
            base::Time creation_time,
            const std::string& serialized_report)
         : report_id(report_id),
@@ skipping 78 matching lines @@
     // Current report id, starting from zero and monotonically incrementing.
     int current_report_id_;
 
     std::map<int, Report> inflight_reports_;
 
     base::WeakPtrFactory<Reporter> weak_factory_;
 
     DISALLOW_COPY_AND_ASSIGN(Reporter);
   };
 
+  static const char kReportEventHistogram[];

[estark, 2017/05/05 16:21:13]

nit: also "Public for testing"

[meacer, 2017/05/05 19:24:19]

Done.

+
   CertificateReportingService(
       safe_browsing::SafeBrowsingService* safe_browsing_service,
       scoped_refptr<net::URLRequestContextGetter> url_request_context_getter,
       Profile* profile,
       uint8_t server_public_key[/* 32 */],
       uint32_t server_public_key_version,
       size_t max_queued_report_count,
       base::TimeDelta max_report_age,
       base::Clock* clock,
       const base::Callback<void()>& reset_callback);
@@ skipping 74 matching lines @@
   base::Callback<void()> reset_callback_;
 
   // Encryption parameters.
   uint8_t* server_public_key_;
   uint32_t server_public_key_version_;
 
   DISALLOW_COPY_AND_ASSIGN(CertificateReportingService);
 };
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_CERTIFICATE_REPORTING_SERVICE_H_