Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: pkg/compiler/lib/src/js_backend/namer.dart

Issue 2862433002: Fix for issue 28196 - constant interceptors for mixin applications (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/html/custom/mirrors_2_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/namer.dart
diff --git a/pkg/compiler/lib/src/js_backend/namer.dart b/pkg/compiler/lib/src/js_backend/namer.dart
index d4813ad51173c3d0c05f91ec07b8d8a1138f1232..784a9405af9e2179f1d422f8435df81b0c35e494 100644
--- a/pkg/compiler/lib/src/js_backend/namer.dart
+++ b/pkg/compiler/lib/src/js_backend/namer.dart
@@ -1892,7 +1892,8 @@ class ConstantNamingVisitor implements ConstantValueVisitor {
@override
void visitInterceptor(InterceptorConstantValue constant, [_]) {
- addRoot(constant.cls.name);
+ // The class name for mixin applications contain '+' signs (issue 28196).
+ addRoot(constant.cls.name.replaceAll('+', '_'));
add('methods');
}
« no previous file with comments | « no previous file | tests/html/custom/mirrors_2_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698