Issue 286243004: [Android] Add GestureStateListener hook for all single-tap event acks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 286243004: [Android] Add GestureStateListener hook for all single-tap event acks (Closed)

Created:
6 years, 7 months ago by jdduke (slow)

Modified:
6 years, 7 months ago

Reviewers:
Ted C

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] Add GestureStateListener hook for all single-tap event acks Previously, GestureStateListener provided a method for listening to unhandled tap events. Expand this to include handled taps, useful for logging general site interaction metrics. BUG=374335 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271227

Patch Set 1 #

Patch Set 2 : No downstream clients, yay #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
M	content/browser/android/content_view_core_impl.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content_public/browser/GestureStateListener.java	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jdduke (slow)

tedchoc@: PTAL. The GestureStateListener interface is a bit of a mess (yay evolution), someday I'd ...

6 years, 7 months ago (2014-05-16 19:13:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/286243004/20001

6 years, 7 months ago (2014-05-16 20:11:00 UTC) #4

Message was sent while issue was closed.

Change committed as 271227

Expand Messages | Collapse Messages