Move JavascriptTestObserver from chrome to content.

Move JavascriptTestObserver from chrome to content.

This change moves the test support class JavascriptTestObserver from
chrome/test to content/public/test. This test doesn't have any dependencies on
anything in chrome/, and moving it will allow tests in content to use this
utility class.

This class has to move to content to allow moving some Pepper testing from
chrome/ to content/

BUG=371873
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271209

[jam, 2014-05-16 17:56:36]

lgtm

https://codereview.chromium.org/286243003/diff/100001/content/public/test/jav...
File content/public/test/javascript_test_observer.h (right):

https://codereview.chromium.org/286243003/diff/100001/content/public/test/jav...
content/public/test/javascript_test_observer.h:58: class JavascriptTestObserver
: public content::NotificationObserver {
nit: here and below, and in the cc file, remove "content::"

[teravest, 2014-05-16 18:00:20]

Thanks for the quick review!

On Fri, May 16, 2014 at 11:56 AM,  <jam@chromium.org> wrote:
> lgtm
>
>
>
>
>
https://codereview.chromium.org/286243003/diff/100001/content/public/test/jav...
> File content/public/test/javascript_test_observer.h (right):
>
>
https://codereview.chromium.org/286243003/diff/100001/content/public/test/jav...
> content/public/test/javascript_test_observer.h:58: class
> JavascriptTestObserver : public content::NotificationObserver {
> nit: here and below, and in the cc file, remove "content::"

Done.

>
> https://codereview.chromium.org/286243003/

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[teravest, 2014-05-16 18:00:21]

Thanks for the quick review!

On Fri, May 16, 2014 at 11:56 AM,  <jam@chromium.org> wrote:
> lgtm
>
>
>
>
>
https://codereview.chromium.org/286243003/diff/100001/content/public/test/jav...
> File content/public/test/javascript_test_observer.h (right):
>
>
https://codereview.chromium.org/286243003/diff/100001/content/public/test/jav...
> content/public/test/javascript_test_observer.h:58: class
> JavascriptTestObserver : public content::NotificationObserver {
> nit: here and below, and in the cc file, remove "content::"

Done.

>
> https://codereview.chromium.org/286243003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[teravest, 2014-05-16 18:00:29]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-05-16 18:01:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/teravest@chromium.org/286243003/120001

[commit-bot: I haz the power, 2014-05-16 20:57:38]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-17 06:22:51]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-17 15:43:12]

Change committed as 271209