components/autofill/core/browser/autofill_driver.h - Issue 286243002: Mac: Autofill should not immediately request access to address book.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_driver.h

Issue 286243002: Mac: Autofill should not immediately request access to address book. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a missing abstract method override to a test class. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/autofill_agent.cc ('k') | components/autofill/core/browser/autofill_external_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_driver.h

diff --git a/components/autofill/core/browser/autofill_driver.h b/components/autofill/core/browser/autofill_driver.h

index efc5696ccc0b2d4fed3b9dadf67e8a09c99bd01e..748ad6e5b4a87be08347eae195f74e5700da2b7b 100644

--- a/components/autofill/core/browser/autofill_driver.h

+++ b/components/autofill/core/browser/autofill_driver.h

@@ -58,6 +58,9 @@ class AutofillDriver {

RendererFormDataAction action,

const FormData& data) = 0;

+ // Pings renderer. The renderer will return an IPC acknowledging the ping.

+ virtual void PingRenderer() = 0;

// Sends the field type predictions specified in |forms| to the renderer. This

// method is a no-op if the renderer is not available or the appropriate

// command-line flag is not set.

@@ -81,7 +84,6 @@ class AutofillDriver {

// Tells the renderer to preview the node with suggested text.

virtual void RendererShouldPreviewFieldWithValue(

const base::string16& value) = 0;

};

} // namespace autofill