components/autofill/core/browser/autofill_external_delegate.h - Issue 286243002: Mac: Autofill should not immediately request access to address book.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate.h

Issue 286243002: Mac: Autofill should not immediately request access to address book. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from isherman. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_driver.h ('k') | components/autofill/core/browser/autofill_external_delegate.cc » ('j') | components/autofill/core/browser/autofill_external_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_external_delegate.h

diff --git a/components/autofill/core/browser/autofill_external_delegate.h b/components/autofill/core/browser/autofill_external_delegate.h

index 672b2d63d18955557b72fa32fb7a86cbb7f57b67..2ebe0f647d24df0024d5fc8e7ec477763e9c350f 100644

--- a/components/autofill/core/browser/autofill_external_delegate.h

+++ b/components/autofill/core/browser/autofill_external_delegate.h

@@ -80,6 +80,9 @@ class AutofillExternalDelegate

// values or settings.

void Reset();

+ // The renderer sent an IPC acknowledging an earlier ping IPC.

+ void OnPingAck();

protected:

base::WeakPtr<AutofillExternalDelegate> GetWeakPtr();

@@ -111,6 +114,11 @@ class AutofillExternalDelegate

std::vector<base::string16>* icons,

std::vector<int>* unique_ids);

+#if defined(OS_MACOSX)

+ // Pings the renderer.

+ void PingRenderer();

+#endif

AutofillManager* manager_; // weak.

// Provides driver-level context to the shared code of the component. Must