components/autofill/content/common/autofill_messages.h - Issue 286243002: Mac: Autofill should not immediately request access to address book.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 286243002: Mac: Autofill should not immediately request access to address book. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from isherman. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/browser/content_autofill_driver.cc ('k') | components/autofill/content/renderer/autofill_agent.h » ('j') | components/autofill/core/browser/autofill_external_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index 0fa84302fedee7c1cc7d7e4f5b3aeca4af514d47..092955e6bf950888a77d186583fa72dc9859ab5e 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -94,6 +94,11 @@ IPC_ENUM_TRAITS_MAX_VALUE(

// Autofill messages sent from the browser to the renderer.

+// Instructs the renderer to immediately return an IPC acknowledging the ping.

+// This is used to correctly sequence events, since IPCs are guaranteed to be

+// processed in order.

+IPC_MESSAGE_ROUTED0(AutofillMsg_Ping)

// Instructs the renderer to fill the active form with the given form data.

IPC_MESSAGE_ROUTED2(AutofillMsg_FillForm,

int /* query_id */,

@@ -221,6 +226,9 @@ IPC_MESSAGE_ROUTED5(AutofillHostMsg_QueryFormFieldAutofill,

// Sent when a form is previewed with Autofill suggestions.

IPC_MESSAGE_ROUTED0(AutofillHostMsg_DidPreviewAutofillFormData)

+// Sent immediately after the renderer receives a ping IPC.

+IPC_MESSAGE_ROUTED0(AutofillHostMsg_PingAck)

// Sent when a form is filled with Autofill suggestions.

IPC_MESSAGE_ROUTED1(AutofillHostMsg_DidFillAutofillFormData,

base::TimeTicks /* timestamp */)