Mac: Autofill should not immediately request access to address book.

components/autofill/core/browser/personal_data_manager.h

Index: components/autofill/core/browser/personal_data_manager.h
diff --git a/components/autofill/core/browser/personal_data_manager.h b/components/autofill/core/browser/personal_data_manager.h
index 9ddc98e5bfff9acbad985ac93e5932d847daaac0..6302e05d097a19ac0a775daf74a4de8bb4c46344 100644
--- a/components/autofill/core/browser/personal_data_manager.h
+++ b/components/autofill/core/browser/personal_data_manager.h
@@ -200,6 +200,23 @@ class PersonalDataManager : public KeyedService,
   // will only update when Chrome is restarted.
   virtual const std::string& GetDefaultCountryCodeForNewAddress() const;
 
+#if defined(OS_MACOSX)
+  // If Chrome has not prompted for access to the user's address book, the
+  // method prompts the user for permission and blocks the process. Otherwise,
+  // this method has no effect. The return value reflects whether the user was
+  // prompted with a modal dialog.
+  bool AccessAddressBook();
+
+  // If Chrome has not prompted for access to the user's address book, the
+  // method prompts the user for permission and blocks the process. Otherwise,
+  // this method has no effect. The return value reflects whether the user was
+  // prompted with a modal dialog.

[Ilya Sherman, 2014/05/22 15:13:59]

nit: Please update this comment.

[erikchen, 2014/05/22 20:40:59]

Done.

+  bool ShouldShowAccessAddressBookSuggestion(
+      const FormData& data,
+      const FormFieldData& field_data,
+      const ScopedVector<FormStructure>& form_structures);

[Ilya Sherman, 2014/05/22 15:13:59]

Note: It's generally better to pass the underlying std::vector, rather than
passing a ScopedVector.

[erikchen, 2014/05/22 20:40:59]

I've used your earlier suggestion of just passing in a type.

+#endif  // defined(OS_MACOSX)
+
  protected:
   // Only PersonalDataManagerFactory and certain tests can create instances of
   // PersonalDataManager.