Mac: Autofill should not immediately request access to address book.

components/autofill/core/browser/personal_data_manager.h

Index: components/autofill/core/browser/personal_data_manager.h
diff --git a/components/autofill/core/browser/personal_data_manager.h b/components/autofill/core/browser/personal_data_manager.h
index 9ddc98e5bfff9acbad985ac93e5932d847daaac0..483616eabc2f65b14168fd81adeebdfc2e575233 100644
--- a/components/autofill/core/browser/personal_data_manager.h
+++ b/components/autofill/core/browser/personal_data_manager.h
@@ -200,6 +200,16 @@ class PersonalDataManager : public KeyedService,
   // will only update when Chrome is restarted.
   virtual const std::string& GetDefaultCountryCodeForNewAddress() const;
 
+#if defined(OS_MACOSX)
+  // Whether Chromium has prompted the user for permission to access the user's

[Ilya Sherman, 2014/05/21 11:29:15]

nit: "Chromium" -> "Chrome" (in general, comments in the code refer to "Chrome"
(the main binary that we ship), even though the open source project name is
Chromium).

[erikchen, 2014/05/21 22:00:54]

good to know, thanks!

+  // address book.
+  bool HasPromptedForAccessToAddressBook();

[Ilya Sherman, 2014/05/21 11:29:15]

nit: Please leave a blank line after this one.

[erikchen, 2014/05/21 22:00:54]

Done.

+  // If Chromium has not prompted for access to the user's address book, prompts

[Ilya Sherman, 2014/05/21 11:29:15]

nit: Ditto.

[erikchen, 2014/05/21 22:00:54]

Done. I made sure that the diff file has no more references to 'Chromium'.

+  // the user for permission and blocks the process. Otherwise, this method has
+  // no effect.
+  void AccessAddressBook();
+#endif  // defined(OS_MACOSX)
+
  protected:
   // Only PersonalDataManagerFactory and certain tests can create instances of
   // PersonalDataManager.