Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: components/autofill/core/browser/autofill_manager.h

Issue 286243002: Mac: Autofill should not immediately request access to address book. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address second round of comments from isherman. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 autofill::AutofillManagerDelegate* delegate, 77 autofill::AutofillManagerDelegate* delegate,
78 const std::string& app_locale, 78 const std::string& app_locale,
79 AutofillDownloadManagerState enable_download_manager); 79 AutofillDownloadManagerState enable_download_manager);
80 virtual ~AutofillManager(); 80 virtual ~AutofillManager();
81 81
82 // Sets an external delegate. 82 // Sets an external delegate.
83 void SetExternalDelegate(AutofillExternalDelegate* delegate); 83 void SetExternalDelegate(AutofillExternalDelegate* delegate);
84 84
85 void ShowAutofillSettings(); 85 void ShowAutofillSettings();
86 86
87 #if defined(OS_MACOSX)
88 // Whether the field represented by |fieldData| should show an entry to prompt
89 // the user to give Chrome access to the user's address book.
90 bool ShouldShowAccessAddressBookSuggestion(const FormData& data,
91 const FormFieldData& field_data);
Ilya Sherman 2014/05/22 15:13:59 nit: Please leave a blank line after this one.
erikchen 2014/05/22 20:40:59 Done.
92 // If Chrome has not prompted for access to the user's address book, the
93 // method prompts the user for permission and blocks the process. Otherwise,
94 // this method has no effect. The return value reflects whether the user was
95 // prompted with a modal dialog.
96 bool AccessAddressBook();
97 #endif // defined(OS_MACOSX)
98
87 // Called from our external delegate so they cannot be private. 99 // Called from our external delegate so they cannot be private.
88 virtual void FillOrPreviewForm(AutofillDriver::RendererFormDataAction action, 100 virtual void FillOrPreviewForm(AutofillDriver::RendererFormDataAction action,
89 int query_id, 101 int query_id,
90 const FormData& form, 102 const FormData& form,
91 const FormFieldData& field, 103 const FormFieldData& field,
92 int unique_id); 104 int unique_id);
93 void DidShowSuggestions(bool is_new_popup); 105 void DidShowSuggestions(bool is_new_popup);
94 void OnDidFillAutofillFormData(const base::TimeTicks& timestamp); 106 void OnDidFillAutofillFormData(const base::TimeTicks& timestamp);
95 void OnDidPreviewAutofillFormData(); 107 void OnDidPreviewAutofillFormData();
96 108
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 UserHappinessFormLoadAndSubmission); 369 UserHappinessFormLoadAndSubmission);
358 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction); 370 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
359 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 371 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
360 FormSubmittedAutocompleteEnabled); 372 FormSubmittedAutocompleteEnabled);
361 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 373 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
362 }; 374 };
363 375
364 } // namespace autofill 376 } // namespace autofill
365 377
366 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 378 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698