Mac: Autofill should not immediately request access to address book.

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 12 matching lines @@
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
 #include "components/autofill/core/browser/autofill_data_model.h"
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/autofill_manager_delegate.h"
 #include "components/autofill/core/browser/autofill_manager_test_delegate.h"
 #include "components/autofill/core/browser/autofill_metrics.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/autofill_type.h"
 #include "components/autofill/core/browser/credit_card.h"
+#include "components/autofill/core/browser/field_types.h"
 #include "components/autofill/core/browser/form_structure.h"
 #include "components/autofill/core/browser/personal_data_manager.h"
 #include "components/autofill/core/browser/phone_number.h"
 #include "components/autofill/core/browser/phone_number_i18n.h"
 #include "components/autofill/core/browser/popup_item_ids.h"
 #include "components/autofill/core/common/autofill_data_validation.h"
 #include "components/autofill/core/common/autofill_pref_names.h"
 #include "components/autofill/core/common/autofill_switches.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_data_predictions.h"
@@ skipping 190 matching lines @@
   // work if the delegate has a pointer to the AutofillManager, but
   // future directions may not need such a pointer.
   external_delegate_ = delegate;
   autocomplete_history_manager_->SetExternalDelegate(delegate);
 }
 
 void AutofillManager::ShowAutofillSettings() {
   manager_delegate_->ShowAutofillSettings();
 }
 
+bool AutofillManager::ShouldShowAccessMacContacts(
+    const FormData& data,
+    const FormFieldData& fieldData) {
+  if (personal_data_->HasAccessMacContacts())
+    return false;
+
+  for (auto it : form_structures_) {

[erikchen, 2014/05/16 22:37:05]

I couldn't find another way to get the type of the field. Suggestions?

+    // The form does not match.
+    if (it->ToFormData().name != data.name)
+      continue;
+    for (size_t index = 0; index < it->field_count(); ++index) {
+      const AutofillField* field = it->field(index);
+      // The field does not match.
+      if (field->name != fieldData.name)
+        continue;
+
+      switch (field->Type().group()) {
+        case ADDRESS_BILLING:
+        case ADDRESS_HOME:
+        case EMAIL:
+        case NAME:
+        case NAME_BILLING:
+        case PHONE_BILLING:
+        case PHONE_HOME:
+          return true;
+        case NO_GROUP:
+        case COMPANY:
+        case CREDIT_CARD:
+        case PASSWORD_FIELD:
+          return false;
+      }
+    }
+  }
+
+  return false;
+}
+
+void AutofillManager::AccessMacContacts() {
+  personal_data_->AccessMacContacts();
+}
+
 bool AutofillManager::OnFormSubmitted(const FormData& form,
                                       const TimeTicks& timestamp) {
   if (!IsValidFormData(form))
     return false;
 
   // Let Autocomplete know as well.
   autocomplete_history_manager_->OnFormSubmitted(form);
 
   // Grab a copy of the form data.
   scoped_ptr<FormStructure> submitted_form(new FormStructure(form));
@@ skipping 885 matching lines @@
     return false;
 
   // Disregard forms that we wouldn't ever autofill in the first place.
   if (!form.ShouldBeParsed(true))
     return false;
 
   return true;
 }
 
 }  // namespace autofill