Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1592)

Unified Diff: chrome/browser/media/router/create_presentation_connection_request.h

Issue 2862393002: [Media Router] Force DEFAULT cast mode when starting presentations from content. (Closed)
Patch Set: Update unittests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/create_presentation_connection_request.h
diff --git a/chrome/browser/media/router/create_presentation_connection_request.h b/chrome/browser/media/router/create_presentation_connection_request.h
index 4c9d5aa4f14e0c1ef286a4e37e2eb6c57b05427f..51b96b6dc16dbcbef3435d4b15ce2611adcde80e 100644
--- a/chrome/browser/media/router/create_presentation_connection_request.h
+++ b/chrome/browser/media/router/create_presentation_connection_request.h
@@ -32,6 +32,8 @@ class RouteRequestResult;
// presentation_service_delegate_impl, which is then passed to and owned by the
// MediaRouterUI. |success_cb| will be invoked when create-session succeeds, or
// |error_cb| will be invoked when create-session fails or the UI closes.
+// TODO(mfoltz): Combine this with PresentationRequest as it's largely
+// redundant.
class CreatePresentationConnectionRequest {
public:
using PresentationConnectionCallback =
@@ -42,8 +44,9 @@ class CreatePresentationConnectionRequest {
// URL.
// |frame_origin|: The origin of the frame that initiated the presentation
// request.
+ // |is_top_level_frame|: True if the request is from a top level frame.
takumif 2017/05/16 21:51:28 No longer necessary?
mark a. foltz 2017/05/16 22:02:11 Removed.
// |success_cb|: Callback to invoke when the request succeeds. Must be valid.
- // |erorr_cb|: Callback to invoke when the request fails. Must be valid.
+ // |error_cb|: Callback to invoke when the request fails. Must be valid.
CreatePresentationConnectionRequest(
const RenderFrameHostId& render_frame_host_id,
const std::vector<GURL>& presentation_urls,

Powered by Google App Engine
This is Rietveld 408576698