Chromium Code Reviews| Index: runtime/observatory/lib/src/elements/instance_ref.dart |
| diff --git a/runtime/observatory/lib/src/elements/instance_ref.dart b/runtime/observatory/lib/src/elements/instance_ref.dart |
| index d5cff50c2959fbefa583ff05208034427de25554..856bf30413a957158cb1fd8b9f96e9f14884ae61 100644 |
| --- a/runtime/observatory/lib/src/elements/instance_ref.dart |
| +++ b/runtime/observatory/lib/src/elements/instance_ref.dart |
| @@ -137,8 +137,8 @@ class InstanceRefElement extends HtmlElement implements Renderable { |
| ..children = [ |
| new SpanElement() |
| ..classes = ['emphasize'] |
| - ..text = 'Closure', |
| - new SpanElement()..text = _instance.closureFunction.name |
| + ..text = "Closure", |
|
aam
2017/05/09 17:44:19
Are double quotes (vs single quotes that seem to b
rmacnak
2017/05/09 17:47:54
No, just C++ on the brain :)
|
| + new SpanElement()..text = " (${_instance.closureFunction.name})" |
| ] |
| ]; |
| case M.InstanceKind.regExp: |
| @@ -148,18 +148,16 @@ class InstanceRefElement extends HtmlElement implements Renderable { |
| new SpanElement() |
| ..classes = ['emphasize'] |
| ..text = _instance.clazz.name, |
| - new SpanElement()..text = _instance.pattern.name |
| + new SpanElement()..text = " (${_instance.pattern.valueAsString})" |
| ] |
| ]; |
| case M.InstanceKind.stackTrace: |
| return [ |
| new AnchorElement(href: Uris.inspect(_isolate, object: _instance)) |
| - ..text = _instance.clazz.name, |
| - new CurlyBlockElement(queue: _r.queue) |
| - ..content = [ |
| - new DivElement() |
| - ..classes = ['stackTraceBox'] |
| - ..text = _instance.valueAsString |
| + ..children = [ |
| + new SpanElement() |
| + ..classes = ['emphasize'] |
| + ..text = _instance.clazz.name, |
| ] |
| ]; |
| case M.InstanceKind.plainInstance: |
| @@ -206,13 +204,14 @@ class InstanceRefElement extends HtmlElement implements Renderable { |
| ..text = _instance.clazz.name |
| ]; |
| } |
| - throw new Exception('Unkown InstanceKind: ${_instance.kind}'); |
| + throw new Exception('Unknown InstanceKind: ${_instance.kind}'); |
| } |
| bool _hasValue() { |
| switch (_instance.kind) { |
| case M.InstanceKind.plainInstance: |
| case M.InstanceKind.mirrorReference: |
| + case M.InstanceKind.stackTrace: |
| case M.InstanceKind.weakProperty: |
| return true; |
| case M.InstanceKind.list: |
| @@ -298,6 +297,12 @@ class InstanceRefElement extends HtmlElement implements Renderable { |
| new InstanceRefElement(_isolate, _loadedInstance.referent, _instances, |
| queue: _r.queue) |
| ]; |
| + case M.InstanceKind.stackTrace: |
| + return [ |
| + new DivElement() |
| + ..classes = ['stackTraceBox'] |
| + ..text = _instance.valueAsString |
| + ]; |
| case M.InstanceKind.weakProperty: |
| return [ |
| new SpanElement()..text = '<key> : ', |