Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1427)

Unified Diff: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java

Issue 2862353003: [Crash Reporting] Fix a race between uploading and appending logcat data. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java
diff --git a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java
index bd3e72764b0c1c6e83f36c6d3d2d86f38762d54b..8dacd4e4cd90b0b5687baf20426a3f0b196866b7 100644
--- a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java
+++ b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java
@@ -46,4 +46,17 @@ public interface MinidumpUploaderDelegate {
* @param minidump The minidump filename, prior to the upload attempt.
*/
void recordUploadFailure(File minidump);
+
+ /**
+ * Prior to M60, the ".tryN" suffix was optional for files ready to be uploaded; it is now
+ * required. Clients may implement this method to migrate previously saved minidumps to the new
+ * naming scheme, if necessary.
+ * Note: Because renaming files is a file operation, this method should never be called on the
+ * UI thread; only on a background thread.
+ * @param crashfileManager The file manager responsible for the set of minidumps that might need
+ * migration.
+ * TODO(isherman): This is temporary migration logic, and can be removed in M61:
+ * http://crbug.com/719120.
+ */
+ void migrateMinidumpFilenamesIfNeeded(CrashFileManager crashFileManager);
}

Powered by Google App Engine
This is Rietveld 408576698