Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1991)

Unified Diff: android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java

Issue 2862353003: [Crash Reporting] Fix a race between uploading and appending logcat data. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
diff --git a/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java b/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
index ff7b8d530c205a046491272a32041616a5b81130..dcc409d8b3ea6effbc93e68796b4bb3deb005c0b 100644
--- a/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
+++ b/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
@@ -14,6 +14,7 @@ import org.chromium.base.CommandLine;
import org.chromium.base.ContextUtils;
import org.chromium.base.ThreadUtils;
import org.chromium.base.VisibleForTesting;
+import org.chromium.components.minidump_uploader.CrashFileManager;
import org.chromium.components.minidump_uploader.MinidumpUploaderDelegate;
import org.chromium.components.minidump_uploader.util.CrashReportingPermissionManager;
import org.chromium.components.minidump_uploader.util.NetworkPermissionUtil;
@@ -90,4 +91,12 @@ public class AwMinidumpUploaderDelegate implements MinidumpUploaderDelegate {
@Override
public void recordUploadFailure(File minidump) {}
+
+ @Override
+ public void migrateMinidumpFilenamesIfNeeded(CrashFileManager crashFileManager) {
+ File[] minidumpFilesUsingOldNamingScheme = crashFileManager.getMinidumpsSansLogcat();
+ for (File minidump : minidumpFilesUsingOldNamingScheme) {
+ CrashFileManager.trySetReadyForUpload(minidump);
+ }
+ }
}

Powered by Google App Engine
This is Rietveld 408576698