Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html

Issue 2862353002: Upstream service worker `fetch` tests to WPT (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html
index 609ac6e433a88b35191f40879e3eddad4a4fc429..738a537a655103c01112a5ba61d1a72683c744b5 100644
--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html
+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html
@@ -67,6 +67,8 @@ function get_sorted_header_name_list(headers) {
function get_header_test() {
return xhr_send(host_info['HTTP_ORIGIN'], 'GET', '', false)
.then(function(response) {
+ // This assertion is invalid because the User-Agent header should not
+ // be present.
assert_array_equals(
get_sorted_header_name_list(response.headers),
["accept", "user-agent"],
@@ -75,7 +77,7 @@ function get_header_test() {
}
// TODO(tyoshino): Fix the stack not to include the Origin header as specified
-// in the spec.
+// in the spec. Likewise, the User-Agent header should not be present.
function post_header_test() {
return xhr_send(host_info['HTTP_ORIGIN'], 'POST', '', false)
.then(function(response) {
@@ -89,6 +91,8 @@ function post_header_test() {
function cross_origin_get_header_test() {
return xhr_send(host_info['HTTP_REMOTE_ORIGIN'], 'GET', '', false)
.then(function(response) {
+ // This assertion is invalid because the User-Agent header should not
+ // be present.
assert_array_equals(
get_sorted_header_name_list(response.headers),
["accept", "user-agent"],
@@ -97,7 +101,7 @@ function cross_origin_get_header_test() {
}
// TODO(tyoshino): Fix the stack not to include the Origin header as specified
-// in the spec.
+// in the spec. Likewise, the User-Agent header should not be present.
function cross_origin_post_header_test() {
return xhr_send(host_info['HTTP_REMOTE_ORIGIN'], 'POST', '', false)
.then(function(response) {

Powered by Google App Engine
This is Rietveld 408576698