third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-request-xhr.html - Issue 2862353002: Upstream service worker `fetch` tests to WPT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-request-xhr.html

Issue 2862353002: Upstream service worker `fetch` tests to WPT (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-response-xhr.https.html ('K') | « third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-request-css-base-url.html ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-response-xhr.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-request-xhr.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-xhr.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-request-xhr.html

similarity index 70%

rename from third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-xhr.html

rename to third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-request-xhr.html

index 85dbe4c9cb9a04b693817e62e1b383b7224691b2..133e7b4a88c2de8d5faf1ed2cc20fc7261bfd283 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-xhr.html

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-request-xhr.html

@@ -1,4 +1,14 @@

<!DOCTYPE html>

+<!-- This test is prefixed with `chromium.` because the equivalent version

+ available in Web Platform Tests is known to cause timeout errors in the

+ Chromium automated build system. See https://crbug.com/658997

+ Furthermore, the upstream version is more strict, and Chromium currently

+ fails it. See https://crbug.com/595993

+ This version should be maintained only to preserve test coverage until the

+ corresponding version in Web Platform Tests can be made to pass consistently.

+ -->

<title>Service Worker: the body of FetchEvent using XMLHttpRequest</title>

@@ -15,10 +25,10 @@ async_test(function(t) {

})

.then(function() { return with_iframe(SCOPE); })

.then(function(frame) {

+ t.add_cleanup(function() { frame.remove(); });

var channel = new MessageChannel();

channel.port1.onmessage = t.step_func(function(e) {

assert_equals(e.data.results, 'finish');

- frame.remove();

service_worker_unregister_and_done(t, SCOPE);

});

frame.contentWindow.postMessage({},