Upstream service worker `fetch` tests to WPT

third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-xhr.https.html

Index: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-xhr.https.html
diff --git a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-xhr.https.html b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-xhr.https.html
index 87af410999402721b1310ad1f54a75a85403600f..e7218edf1591b6083c667f9153af04d0f86ae2cf 100644
--- a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-xhr.https.html
+++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-xhr.https.html
@@ -15,13 +15,17 @@ async_test(function(t) {
         })
       .then(function() { return with_iframe(SCOPE); })
       .then(function(frame) {
+          t.add_cleanup(function() { frame.remove(); });
           var channel = new MessageChannel();
           channel.port1.onmessage = t.step_func(function(e) {

[Marijn Kruisselbrink, 2017/05/05 23:59:00]

random thought: it seems like this test could be cleaned up a bit by using
fetch_tests_from_window (i.e. rather than the custom MessageChannel/postMessage
protocol, you could just use that to have regular testharness.js tests in the
iframe, and load the results that way). Not sure how cleanup/uninstalling the
service worker would be dealt with in that case though...

[mike3, 2017/05/08 18:41:40]

I've been working on an extension to the "multiglobal" tests to support Service
Workers:

https://github.com/bocoup/web-platform-tests/commit/f6775c1991db37973b162d769...

Since this test requires an iframe, it's not directly applicable, but it does
introduce a callback to `fetch_test_from_worker`, which suggests that a similar
extension to `fetch_test_from_window` might make sense. Still, that's a little
ways off, though, so I think I'd like to land this particular test as-is.

[Marijn Kruisselbrink, 2017/05/08 19:05:13]

Agreed, landing as is is fine. Adding a done callback like in that CL does seem
like a good idea, yes. Or maybe a generic async cleanup mechanism... 

               if (e.data.results === 'finish') {
-                frame.remove();
                 service_worker_unregister_and_done(t, SCOPE);
               } else if (e.data.results == 'equals') {
                 assert_equals(e.data.got, e.data.expected);
+              } else if (e.data.results == 'array_equals') {
+                assert_array_equals(e.data.got, e.data.expected, e.data.msg);
+              } else if (e.data.results == 'failure') {
+                throw e.data.error;
               }
             });
           frame.contentWindow.postMessage({},