| OLD | NEW |
|---|
| (Empty) |
| 1 // Copyright 2017 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #include "base/metrics/single_sample_metrics.h" | |
| 6 | |
| 7 #include "base/memory/ptr_util.h" | |
| 8 #include "base/test/gtest_util.h" | |
| 9 #include "base/test/histogram_tester.h" | |
| 10 #include "testing/gtest/include/gtest/gtest.h" | |
| 11 | |
| 12 namespace base { | |
| 13 | |
| 14 namespace { | |
| 15 | |
| 16 const HistogramBase::Sample kMin = 1; | |
| 17 const HistogramBase::Sample kMax = 10; | |
| 18 const uint32_t kBucketCount = 10; | |
| 19 const char kMetricName[] = "Single.Sample.Metric"; | |
| 20 | |
| 21 class SingleSampleMetricsTest : public testing::Test { | |
| 22 public: | |
| 23 SingleSampleMetricsTest() {} | |
| 24 | |
| 25 ~SingleSampleMetricsTest() override { | |
| 26 // Ensure we cleanup after ourselves. | |
| 27 SingleSampleMetricsFactory::DeleteFactoryForTesting(); | |
| 28 } | |
| 29 | |
| 30 private: | |
| 31 DISALLOW_COPY_AND_ASSIGN(SingleSampleMetricsTest); | |
| 32 }; | |
| 33 | |
| 34 } // namespace | |
| 35 | |
| 36 TEST_F(SingleSampleMetricsTest, DefaultFactoryGetSet) { | |
| 37 SingleSampleMetricsFactory* factory = SingleSampleMetricsFactory::Get(); | |
| 38 ASSERT_TRUE(factory); | |
| 39 | |
| 40 // Same factory should be returned evermore. | |
| 41 EXPECT_EQ(factory, SingleSampleMetricsFactory::Get()); | |
| 42 | |
| 43 // Setting a factory after the default has been instantiated should fail. | |
| 44 EXPECT_DCHECK_DEATH(SingleSampleMetricsFactory::SetFactory( | |
| 45 WrapUnique<SingleSampleMetricsFactory>(nullptr))); | |
| 46 } | |
| 47 | |
| 48 TEST_F(SingleSampleMetricsTest, CustomFactoryGetSet) { | |
| 49 SingleSampleMetricsFactory* factory = new DefaultSingleSampleMetricsFactory(); | |
| 50 SingleSampleMetricsFactory::SetFactory(WrapUnique(factory)); | |
| 51 EXPECT_EQ(factory, SingleSampleMetricsFactory::Get()); | |
| 52 } | |
| 53 | |
| 54 TEST_F(SingleSampleMetricsTest, DefaultSingleSampleMetricNoValue) { | |
| 55 SingleSampleMetricsFactory* factory = SingleSampleMetricsFactory::Get(); | |
| 56 | |
| 57 HistogramTester tester; | |
| 58 std::unique_ptr<SingleSampleMetric> metric = | |
| 59 factory->CreateCustomCountsMetric(kMetricName, kMin, kMax, kBucketCount); | |
| 60 metric.reset(); | |
| 61 | |
| 62 // Verify that no sample is recorded if SetSample() is never called. | |
| 63 tester.ExpectTotalCount(kMetricName, 0); | |
| 64 } | |
| 65 | |
| 66 TEST_F(SingleSampleMetricsTest, DefaultSingleSampleMetricWithValue) { | |
| 67 SingleSampleMetricsFactory* factory = SingleSampleMetricsFactory::Get(); | |
| 68 | |
| 69 HistogramTester tester; | |
| 70 std::unique_ptr<SingleSampleMetric> metric = | |
| 71 factory->CreateCustomCountsMetric(kMetricName, kMin, kMax, kBucketCount); | |
| 72 | |
| 73 const HistogramBase::Sample kLastSample = 9; | |
| 74 metric->SetSample(1); | |
| 75 metric->SetSample(3); | |
| 76 metric->SetSample(5); | |
| 77 metric->SetSample(kLastSample); | |
| 78 metric.reset(); | |
| 79 | |
| 80 // Verify only the last sample sent to SetSample() is recorded. | |
| 81 tester.ExpectUniqueSample(kMetricName, kLastSample, 1); | |
| 82 | |
| 83 // Verify construction implicitly by requesting a histogram with the same | |
| 84 // parameters; this test relies on the fact that histogram objects are unique | |
| 85 // per name. Different parameters will result in a nullptr being returned. | |
| 86 EXPECT_FALSE( | |
| 87 Histogram::FactoryGet(kMetricName, 1, 3, 3, HistogramBase::kNoFlags)); | |
| 88 EXPECT_TRUE(Histogram::FactoryGet(kMetricName, kMin, kMax, kBucketCount, | |
| 89 HistogramBase::kUmaTargetedHistogramFlag)); | |
| 90 } | |
| 91 | |
| 92 TEST_F(SingleSampleMetricsTest, MultipleMetricsAreDistinct) { | |
| 93 SingleSampleMetricsFactory* factory = SingleSampleMetricsFactory::Get(); | |
| 94 | |
| 95 HistogramTester tester; | |
| 96 std::unique_ptr<SingleSampleMetric> metric = | |
| 97 factory->CreateCustomCountsMetric(kMetricName, kMin, kMax, kBucketCount); | |
| 98 std::unique_ptr<SingleSampleMetric> metric2 = | |
| 99 factory->CreateCustomCountsMetric(kMetricName, kMin, kMax, kBucketCount); | |
| 100 const char kMetricName2[] = "Single.Sample.Metric.2"; | |
| 101 std::unique_ptr<SingleSampleMetric> metric3 = | |
| 102 factory->CreateCustomCountsMetric(kMetricName2, kMin, kMax, kBucketCount); | |
| 103 | |
| 104 const HistogramBase::Sample kSample1 = 5; | |
| 105 metric->SetSample(kSample1); | |
| 106 metric2->SetSample(kSample1); | |
| 107 | |
| 108 const HistogramBase::Sample kSample2 = 7; | |
| 109 metric3->SetSample(kSample2); | |
| 110 | |
| 111 metric.reset(); | |
| 112 tester.ExpectUniqueSample(kMetricName, kSample1, 1); | |
| 113 | |
| 114 metric2.reset(); | |
| 115 tester.ExpectUniqueSample(kMetricName, kSample1, 2); | |
| 116 | |
| 117 metric3.reset(); | |
| 118 tester.ExpectUniqueSample(kMetricName2, kSample2, 1); | |
| 119 } | |
| 120 | |
| 121 } // namespace base | |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 2862333002:
Revert of Add support for single sample metrics. (Closed)
