Finish removing FrameLoader::Clear()

third_party/WebKit/Source/core/editing/Editor.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 1022 matching lines @@
       // matches IE but not FF).
       should_style_with_css_(false),
       kill_ring_(WTF::WrapUnique(new KillRing)),
       are_marked_text_matches_highlighted_(false),
       default_paragraph_separator_(kEditorParagraphSeparatorIsDiv),
       overwrite_mode_enabled_(false) {}
 
 Editor::~Editor() {}
 
 void Editor::Clear() {
-  GetFrame().GetInputMethodController().Clear();

[Nate Chapin, 2017/05/17 18:18:59]

This is also called during Document::Shutdown(), so it's redundant here.

[dcheng, 2017/05/22 21:23:26]

Due to InputMethodController::ContextDestroyed()?

I'd say that it's a bit unclear how this whole class works together, but I think
this doesn't make it any worse.

   should_style_with_css_ = false;
   default_paragraph_separator_ = kEditorParagraphSeparatorIsDiv;
   last_edit_command_ = nullptr;
   undo_stack_->Clear();
 }
 
 bool Editor::InsertText(const String& text, KeyboardEvent* triggering_event) {
   return GetFrame().GetEventHandler().HandleTextInputEvent(text,
                                                            triggering_event);
 }
@@ skipping 764 matching lines @@
 
 DEFINE_TRACE(Editor) {
   visitor->Trace(frame_);
   visitor->Trace(last_edit_command_);
   visitor->Trace(undo_stack_);
   visitor->Trace(mark_);
   visitor->Trace(typing_style_);
 }
 
 }  // namespace blink