Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: pkg/front_end/lib/src/fasta/builder/named_type_builder.dart

Issue 2862223002: Rewrite mixin application handling in Fasta. (Closed)
Patch Set: Update status file. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/builder/named_type_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/builder/named_type_builder.dart b/pkg/front_end/lib/src/fasta/builder/named_type_builder.dart
index 9c302758aa979cb654a35e36a10f1a9b98b8de75..62a65df3f4c3923b866ae735bdd5a5d34892e883 100644
--- a/pkg/front_end/lib/src/fasta/builder/named_type_builder.dart
+++ b/pkg/front_end/lib/src/fasta/builder/named_type_builder.dart
@@ -30,6 +30,7 @@ abstract class NamedTypeBuilder<T extends TypeBuilder, R> extends TypeBuilder {
}
void resolveIn(Scope scope) {
+ if (builder != null) return;
Builder member = scope.lookup(name, charOffset, fileUri);
if (member is TypeDeclarationBuilder) {
builder = member;
@@ -55,7 +56,7 @@ abstract class NamedTypeBuilder<T extends TypeBuilder, R> extends TypeBuilder {
StringBuffer printOn(StringBuffer buffer) {
buffer.write(name);
- if (arguments == null) return buffer;
+ if (arguments?.isEmpty ?? true) return buffer;
buffer.write("<");
bool first = true;
for (T t in arguments) {

Powered by Google App Engine
This is Rietveld 408576698