Chromium Code Reviews| Index: pkg/front_end/lib/src/fasta/builder/named_type_builder.dart |
| diff --git a/pkg/front_end/lib/src/fasta/builder/named_type_builder.dart b/pkg/front_end/lib/src/fasta/builder/named_type_builder.dart |
| index 9c302758aa979cb654a35e36a10f1a9b98b8de75..62a65df3f4c3923b866ae735bdd5a5d34892e883 100644 |
| --- a/pkg/front_end/lib/src/fasta/builder/named_type_builder.dart |
| +++ b/pkg/front_end/lib/src/fasta/builder/named_type_builder.dart |
| @@ -30,6 +30,7 @@ abstract class NamedTypeBuilder<T extends TypeBuilder, R> extends TypeBuilder { |
| } |
| void resolveIn(Scope scope) { |
| + if (builder != null) return; |
| Builder member = scope.lookup(name, charOffset, fileUri); |
| if (member is TypeDeclarationBuilder) { |
| builder = member; |
| @@ -55,7 +56,7 @@ abstract class NamedTypeBuilder<T extends TypeBuilder, R> extends TypeBuilder { |
| StringBuffer printOn(StringBuffer buffer) { |
| buffer.write(name); |
| - if (arguments == null) return buffer; |
| + if (arguments?.isEmpty ?? true) return buffer; |
|
Johnni Winther
2017/05/08 10:05:33
This is weird to read. I'd prefer `arguments == nu
ahe
2017/05/08 11:13:15
Other reviewers have said the opposite, so I'm goi
|
| buffer.write("<"); |
| bool first = true; |
| for (T t in arguments) { |