Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2762)

Unified Diff: chrome/browser/resources/print_preview/data/local_parsers.js

Issue 2862203002: Print Preview: Fix data/ errors (Closed)
Patch Set: Make tests pass Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/data/local_parsers.js
diff --git a/chrome/browser/resources/print_preview/data/local_parsers.js b/chrome/browser/resources/print_preview/data/local_parsers.js
index 14ac04bd06ee2a49ecd326762a2293960239364f..e2aeda5560c0c2ea4e9100d8f1de6b1ea922e441 100644
--- a/chrome/browser/resources/print_preview/data/local_parsers.js
+++ b/chrome/browser/resources/print_preview/data/local_parsers.js
@@ -6,7 +6,7 @@ cr.define('print_preview', function() {
'use strict';
/** Namespace that contains a method to parse local print destinations. */
- function LocalDestinationParser() {};
+ function LocalDestinationParser() {}
/**
* Parses a local print destination.
@@ -25,12 +25,12 @@ cr.define('print_preview', function() {
}
return new print_preview.Destination(
destinationInfo.deviceName,
- print_preview.Destination.Type.LOCAL,
- cr.isChromeOS ? print_preview.Destination.Origin.CROS :
- print_preview.Destination.Origin.LOCAL,
+ print_preview.DestinationType.LOCAL,
+ cr.isChromeOS ? print_preview.DestinationOrigin.CROS :
+ print_preview.DestinationOrigin.LOCAL,
destinationInfo.printerName,
false /*isRecent*/,
- print_preview.Destination.ConnectionStatus.ONLINE,
+ print_preview.DestinationConnectionStatus.ONLINE,
options);
};
@@ -45,24 +45,24 @@ cr.define('print_preview', function() {
var returnedPrinters = [];
if (destinationInfo.hasLocalPrinting) {
- returnedPrinters.push(new print_preview.Destination(
- destinationInfo.serviceName,
- print_preview.Destination.Type.LOCAL,
- print_preview.Destination.Origin.PRIVET,
- destinationInfo.name,
- false /*isRecent*/,
- print_preview.Destination.ConnectionStatus.ONLINE,
- { cloudID: destinationInfo.cloudID }));
+ returnedPrinters.push(new print_preview.Destination(
+ destinationInfo.serviceName,
+ print_preview.DestinationType.LOCAL,
+ print_preview.DestinationOrigin.PRIVET,
+ destinationInfo.name,
+ false /*isRecent*/,
+ print_preview.DestinationConnectionStatus.ONLINE,
+ { cloudID: destinationInfo.cloudID }));
}
if (destinationInfo.isUnregistered) {
returnedPrinters.push(new print_preview.Destination(
destinationInfo.serviceName,
- print_preview.Destination.Type.GOOGLE,
- print_preview.Destination.Origin.PRIVET,
+ print_preview.DestinationType.GOOGLE,
+ print_preview.DestinationOrigin.PRIVET,
destinationInfo.name,
false /*isRecent*/,
- print_preview.Destination.ConnectionStatus.UNREGISTERED));
+ print_preview.DestinationConnectionStatus.UNREGISTERED));
}
return returnedPrinters;
@@ -79,16 +79,16 @@ cr.define('print_preview', function() {
ExtensionDestinationParser.parse = function(destinationInfo) {
var provisionalType =
destinationInfo.provisional ?
- print_preview.Destination.ProvisionalType.NEEDS_USB_PERMISSION :
- print_preview.Destination.ProvisionalType.NONE;
+ print_preview.DestinationProvisionalType.NEEDS_USB_PERMISSION :
+ print_preview.DestinationProvisionalType.NONE;
return new print_preview.Destination(
destinationInfo.id,
- print_preview.Destination.Type.LOCAL,
- print_preview.Destination.Origin.EXTENSION,
+ print_preview.DestinationType.LOCAL,
+ print_preview.DestinationOrigin.EXTENSION,
destinationInfo.name,
false /* isRecent */,
- print_preview.Destination.ConnectionStatus.ONLINE,
+ print_preview.DestinationConnectionStatus.ONLINE,
{description: destinationInfo.description || '',
extensionId: destinationInfo.extensionId,
extensionName: destinationInfo.extensionName || '',

Powered by Google App Engine
This is Rietveld 408576698