chrome/browser/resources/print_preview/search/destination_search.js - Issue 2862203002: Print Preview: Fix data/ errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/search/destination_search.js

Issue 2862203002: Print Preview: Fix data/ errors (Closed)

Patch Set: Fix destination resolver Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/search/destination_list_item.js ('k') | chrome/browser/resources/print_preview/search/provisional_destination_resolver.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/search/destination_search.js

diff --git a/chrome/browser/resources/print_preview/search/destination_search.js b/chrome/browser/resources/print_preview/search/destination_search.js

index 33915459b156687deb830e50a3007500cc368a26..94e46fb33b99f414cb70cc11c51d083cde6a8e36 100644

--- a/chrome/browser/resources/print_preview/search/destination_search.js

+++ b/chrome/browser/resources/print_preview/search/destination_search.js

@@ -367,11 +367,11 @@ cr.define('print_preview', function() {

recentDestinations.push(destination);

}

if (destination.isLocal ||

- destination.origin == print_preview.Destination.Origin.DEVICE) {

+ destination.origin == print_preview.DestinationOrigin.DEVICE) {

localDestinations.push(destination);

} else {

if (destination.connectionStatus ==

- print_preview.Destination.ConnectionStatus.UNREGISTERED) {

+ print_preview.DestinationConnectionStatus.UNREGISTERED) {

unregisteredCloudDestinations.push(destination);

} else {

cloudDestinations.push(destination);

@@ -590,7 +590,7 @@ cr.define('print_preview', function() {

// TODO(crbug.com/416701): Upon resolution, update this.

var destinationItem =

(destination.isLocal ||

- destination.origin == print_preview.Destination.Origin.DEVICE) ?

+ destination.origin == print_preview.DestinationOrigin.DEVICE) ?

this.localList_.getDestinationItem(destination.id) :

this.cloudList_.getDestinationItem(destination.id);

assert(destinationItem != null,

@@ -599,7 +599,7 @@ cr.define('print_preview', function() {

// Another printer setup is in process or the printer doesn't need to be

// set up. Reject the setup request directly.

if (this.destinationInConfiguring_ != null ||

- destination.origin != print_preview.Destination.Origin.CROS ||

+ destination.origin != print_preview.DestinationOrigin.CROS ||

destination.capabilities != null) {

destinationItem.onConfigureRequestRejected(

this.destinationInConfiguring_ != null);

@@ -616,7 +616,7 @@ cr.define('print_preview', function() {

* @private

handleConfigureDestination_: function(destination) {

- assert(destination.origin == print_preview.Destination.Origin.CROS,

+ assert(destination.origin == print_preview.DestinationOrigin.CROS,

'Only local printer on Chrome OS requires setup.');

this.destinationInConfiguring_ = destination;

this.destinationStore_.resolveCrosDestination(destination).then(