Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/resources/print_preview/previewarea/margin_control_container.js

Issue 2862203002: Print Preview: Fix data/ errors (Closed)
Patch Set: Fix destination resolver Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/previewarea/margin_control_container.js
diff --git a/chrome/browser/resources/print_preview/previewarea/margin_control_container.js b/chrome/browser/resources/print_preview/previewarea/margin_control_container.js
index d1341c65e02b0fe469db476116be3f367232c671..31085f6d80aaafaf8640ec71090ae289ebc68a0e 100644
--- a/chrome/browser/resources/print_preview/previewarea/margin_control_container.js
+++ b/chrome/browser/resources/print_preview/previewarea/margin_control_container.js
@@ -63,13 +63,13 @@ cr.define('print_preview', function() {
/**
* Convenience array that contains all of the margin controls.
* @type {!Object<
- * !print_preview.ticket_items.CustomMargins.Orientation,
+ * !print_preview.ticket_items.CustomMarginsOrientation,
* !print_preview.MarginControl>}
* @private
*/
this.controls_ = {};
- for (var key in print_preview.ticket_items.CustomMargins.Orientation) {
- var orientation = print_preview.ticket_items.CustomMargins.Orientation[
+ for (var key in print_preview.ticket_items.CustomMarginsOrientation) {
+ var orientation = print_preview.ticket_items.CustomMarginsOrientation[
key];
var control = new print_preview.MarginControl(orientation);
this.controls_[orientation] = control;
@@ -121,16 +121,16 @@ cr.define('print_preview', function() {
};
/**
- * @param {!print_preview.ticket_items.CustomMargins.Orientation} orientation
+ * @param {!print_preview.ticket_items.CustomMarginsOrientation} orientation
* Orientation value to test.
* @return {boolean} Whether the given orientation is TOP or BOTTOM.
* @private
*/
MarginControlContainer.isTopOrBottom_ = function(orientation) {
return orientation ==
- print_preview.ticket_items.CustomMargins.Orientation.TOP ||
+ print_preview.ticket_items.CustomMarginsOrientation.TOP ||
orientation ==
- print_preview.ticket_items.CustomMargins.Orientation.BOTTOM;
+ print_preview.ticket_items.CustomMarginsOrientation.BOTTOM;
};
MarginControlContainer.prototype = {

Powered by Google App Engine
This is Rietveld 408576698