Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/resources/print_preview/native_layer.js

Issue 2862203002: Print Preview: Fix data/ errors (Closed)
Patch Set: Fix destination resolver Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/native_layer.js
diff --git a/chrome/browser/resources/print_preview/native_layer.js b/chrome/browser/resources/print_preview/native_layer.js
index 19c5a53215ff374c1db1f8a0955cf02362a43623..c1af357d86969255ba48b6ca6e2ce0cba7ebff80 100644
--- a/chrome/browser/resources/print_preview/native_layer.js
+++ b/chrome/browser/resources/print_preview/native_layer.js
@@ -329,7 +329,7 @@ cr.define('print_preview', function() {
print_preview.ticket_items.MarginsTypeValue.CUSTOM) {
var customMargins = printTicketStore.customMargins.getValue();
var orientationEnum =
- print_preview.ticket_items.CustomMargins.Orientation;
+ print_preview.ticket_items.CustomMarginsOrientation;
ticket['marginsCustom'] = {
'marginTop': customMargins.get(orientationEnum.TOP),
'marginRight': customMargins.get(orientationEnum.RIGHT),
@@ -411,7 +411,7 @@ cr.define('print_preview', function() {
print_preview.ticket_items.MarginsTypeValue.CUSTOM)) {
var customMargins = printTicketStore.customMargins.getValue();
var orientationEnum =
- print_preview.ticket_items.CustomMargins.Orientation;
+ print_preview.ticket_items.CustomMarginsOrientation;
ticket['marginsCustom'] = {
'marginTop': customMargins.get(orientationEnum.TOP),
'marginRight': customMargins.get(orientationEnum.RIGHT),
@@ -491,7 +491,7 @@ cr.define('print_preview', function() {
var numberFormatSymbols =
print_preview.MeasurementSystem.parseNumberFormat(
initialSettings['numberFormat']);
- var unitType = print_preview.MeasurementSystem.UnitType.IMPERIAL;
+ var unitType = print_preview.MeasurementSystemUnitType.IMPERIAL;
if (initialSettings['measurementSystem'] != null) {
unitType = initialSettings['measurementSystem'];
}
@@ -568,7 +568,7 @@ cr.define('print_preview', function() {
NativeLayer.EventType.GET_CAPABILITIES_FAIL);
getCapsFailEvent.destinationId = destinationId;
getCapsFailEvent.destinationOrigin =
- print_preview.Destination.Origin.LOCAL;
+ print_preview.DestinationOrigin.LOCAL;
this.dispatchEvent(getCapsFailEvent);
},
@@ -583,7 +583,7 @@ cr.define('print_preview', function() {
NativeLayer.EventType.GET_CAPABILITIES_FAIL);
getCapsFailEvent.destinationId = destinationId;
getCapsFailEvent.destinationOrigin =
- print_preview.Destination.Origin.PRIVET;
+ print_preview.DestinationOrigin.PRIVET;
this.dispatchEvent(getCapsFailEvent);
},
@@ -598,7 +598,7 @@ cr.define('print_preview', function() {
NativeLayer.EventType.GET_CAPABILITIES_FAIL);
getCapsFailEvent.destinationId = destinationId;
getCapsFailEvent.destinationOrigin =
- print_preview.Destination.Origin.EXTENSION;
+ print_preview.DestinationOrigin.EXTENSION;
this.dispatchEvent(getCapsFailEvent);
},
@@ -921,7 +921,7 @@ cr.define('print_preview', function() {
* mode.
* @param {string} thousandsDelimeter Character delimeter of thousands digits.
* @param {string} decimalDelimeter Character delimeter of the decimal point.
- * @param {!print_preview.MeasurementSystem.UnitType} unitType Unit type of
+ * @param {!print_preview.MeasurementSystemUnitType} unitType Unit type of
* local machine's measurement system.
* @param {boolean} isDocumentModifiable Whether the document to print is
* modifiable.
@@ -981,7 +981,7 @@ cr.define('print_preview', function() {
/**
* Unit type of local machine's measurement system.
- * @type {string}
+ * @type {print_preview.MeasurementSystemUnitType}
* @private
*/
this.unitType_ = unitType;
@@ -1064,7 +1064,7 @@ cr.define('print_preview', function() {
},
/**
- * @return {!print_preview.MeasurementSystem.UnitType} Unit type of local
+ * @return {!print_preview.MeasurementSystemUnitType} Unit type of local
* machine's measurement system.
*/
get unitType() {
« no previous file with comments | « chrome/browser/resources/print_preview/data/user_info.js ('k') | chrome/browser/resources/print_preview/preview_generator.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698