Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: chrome/browser/resources/print_preview/data/margins.js

Issue 2862203002: Print Preview: Fix data/ errors (Closed)
Patch Set: Fix destination resolver Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/data/margins.js
diff --git a/chrome/browser/resources/print_preview/data/margins.js b/chrome/browser/resources/print_preview/data/margins.js
index c09c0d5197d25d5514d86915bc3546dbd57e4dd6..716ab3adab2f12155c67d47fc52781cc3fb6f74f 100644
--- a/chrome/browser/resources/print_preview/data/margins.js
+++ b/chrome/browser/resources/print_preview/data/margins.js
@@ -17,18 +17,18 @@ cr.define('print_preview', function() {
/**
* Backing store for the margin values in points.
* @type {!Object<
- * !print_preview.ticket_items.CustomMargins.Orientation, number>}
+ * !print_preview.ticket_items.CustomMarginsOrientation, number>}
* @private
*/
this.value_ = {};
- this.value_[print_preview.ticket_items.CustomMargins.Orientation.TOP] = top;
- this.value_[print_preview.ticket_items.CustomMargins.Orientation.RIGHT] =
+ this.value_[print_preview.ticket_items.CustomMarginsOrientation.TOP] = top;
+ this.value_[print_preview.ticket_items.CustomMarginsOrientation.RIGHT] =
right;
- this.value_[print_preview.ticket_items.CustomMargins.Orientation.BOTTOM] =
+ this.value_[print_preview.ticket_items.CustomMarginsOrientation.BOTTOM] =
bottom;
- this.value_[print_preview.ticket_items.CustomMargins.Orientation.LEFT] =
+ this.value_[print_preview.ticket_items.CustomMarginsOrientation.LEFT] =
left;
- };
+ }
/**
* Parses a margins object from the given serialized state.
@@ -38,15 +38,15 @@ cr.define('print_preview', function() {
*/
Margins.parse = function(state) {
return new print_preview.Margins(
- state[print_preview.ticket_items.CustomMargins.Orientation.TOP] || 0,
- state[print_preview.ticket_items.CustomMargins.Orientation.RIGHT] || 0,
- state[print_preview.ticket_items.CustomMargins.Orientation.BOTTOM] || 0,
- state[print_preview.ticket_items.CustomMargins.Orientation.LEFT] || 0);
+ state[print_preview.ticket_items.CustomMarginsOrientation.TOP] || 0,
+ state[print_preview.ticket_items.CustomMarginsOrientation.RIGHT] || 0,
+ state[print_preview.ticket_items.CustomMarginsOrientation.BOTTOM] || 0,
+ state[print_preview.ticket_items.CustomMarginsOrientation.LEFT] || 0);
};
Margins.prototype = {
/**
- * @param {!print_preview.ticket_items.CustomMargins.Orientation}
+ * @param {!print_preview.ticket_items.CustomMarginsOrientation}
* orientation Specifies the margin value to get.
* @return {number} Value of the margin of the given orientation.
*/
@@ -55,7 +55,7 @@ cr.define('print_preview', function() {
},
/**
- * @param {!print_preview.ticket_items.CustomMargins.Orientation}
+ * @param {!print_preview.ticket_items.CustomMarginsOrientation}
* orientation Specifies the margin to set.
* @param {number} value Updated value of the margin in points to modify.
* @return {!print_preview.Margins} A new copy of |this| with the
@@ -65,10 +65,10 @@ cr.define('print_preview', function() {
var newValue = this.clone_();
newValue[orientation] = value;
return new Margins(
- newValue[print_preview.ticket_items.CustomMargins.Orientation.TOP],
- newValue[print_preview.ticket_items.CustomMargins.Orientation.RIGHT],
- newValue[print_preview.ticket_items.CustomMargins.Orientation.BOTTOM],
- newValue[print_preview.ticket_items.CustomMargins.Orientation.LEFT]);
+ newValue[print_preview.ticket_items.CustomMarginsOrientation.TOP],
+ newValue[print_preview.ticket_items.CustomMarginsOrientation.RIGHT],
+ newValue[print_preview.ticket_items.CustomMarginsOrientation.BOTTOM],
+ newValue[print_preview.ticket_items.CustomMarginsOrientation.LEFT]);
},
/**

Powered by Google App Engine
This is Rietveld 408576698