Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Unified Diff: chrome/browser/resources/print_preview/data/cloud_parsers.js

Issue 2862203002: Print Preview: Fix data/ errors (Closed)
Patch Set: Fix destination resolver Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/data/cloud_parsers.js
diff --git a/chrome/browser/resources/print_preview/data/cloud_parsers.js b/chrome/browser/resources/print_preview/data/cloud_parsers.js
index dc6236a9689e923764b3b0b70f0410b8ce364d36..83d6213619acf93f9eb34fe7b67b8295b3450e71 100644
--- a/chrome/browser/resources/print_preview/data/cloud_parsers.js
+++ b/chrome/browser/resources/print_preview/data/cloud_parsers.js
@@ -6,7 +6,7 @@ cr.define('cloudprint', function() {
'use strict';
/** Namespace which contains a method to parse cloud destinations directly. */
- function CloudDestinationParser() {};
+ function CloudDestinationParser() {}
/**
* Enumeration of cloud destination field names.
@@ -56,7 +56,7 @@ cr.define('cloudprint', function() {
* response.
* @param {!Object} json Object that represents a Google Cloud Print search or
* printer response.
- * @param {!print_preview.Destination.Origin} origin The origin of the
+ * @param {!print_preview.DestinationOrigin} origin The origin of the
* response.
* @param {string} account The account this destination is registered for or
* empty string, if origin != COOKIES.
@@ -72,7 +72,7 @@ cr.define('cloudprint', function() {
var tags = json[CloudDestinationParser.Field_.TAGS] || [];
var connectionStatus =
json[CloudDestinationParser.Field_.CONNECTION_STATUS] ||
- print_preview.Destination.ConnectionStatus.UNKNOWN;
+ print_preview.DestinationConnectionStatus.UNKNOWN;
var optionalParams = {
account: account,
tags: tags,
@@ -102,22 +102,22 @@ cr.define('cloudprint', function() {
* Parses the destination type.
* @param {string} typeStr Destination type given by the Google Cloud Print
* server.
- * @return {!print_preview.Destination.Type} Destination type.
+ * @return {!print_preview.DestinationType} Destination type.
* @private
*/
CloudDestinationParser.parseType_ = function(typeStr) {
if (typeStr == CloudDestinationParser.CloudType_.ANDROID ||
typeStr == CloudDestinationParser.CloudType_.IOS) {
- return print_preview.Destination.Type.MOBILE;
+ return print_preview.DestinationType.MOBILE;
} else if (typeStr == CloudDestinationParser.CloudType_.DOCS) {
- return print_preview.Destination.Type.GOOGLE_PROMOTED;
+ return print_preview.DestinationType.GOOGLE_PROMOTED;
} else {
- return print_preview.Destination.Type.GOOGLE;
+ return print_preview.DestinationType.GOOGLE;
}
};
/** Namespace which contains a method to parse printer sharing invitation. */
- function InvitationParser() {};
+ function InvitationParser() {}
/**
* Enumeration of invitation field names.
@@ -176,7 +176,7 @@ cr.define('cloudprint', function() {
var destination = cloudprint.CloudDestinationParser.parse(
json[InvitationParser.Field_.PRINTER],
- print_preview.Destination.Origin.COOKIES,
+ print_preview.DestinationOrigin.COOKIES,
account);
return new print_preview.Invitation(

Powered by Google App Engine
This is Rietveld 408576698