Print Preview: Fix data/ errors

chrome/browser/resources/print_preview/data/print_ticket_store.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   // TODO(rltoscano): Maybe clear print ticket when destination changes. Or
   // better yet, carry over any print ticket state that is possible. I.e. if
   // destination changes, the new destination might not support duplex anymore,
@@ skipping 41 matching lines @@
      * @private
      */
     this.capabilitiesHolder_ = new print_preview.CapabilitiesHolder();
 
     /**
      * Current measurement system. Used to work with margin measurements.
      * @type {!print_preview.MeasurementSystem}
      * @private
      */
     this.measurementSystem_ = new print_preview.MeasurementSystem(
-        ',', '.', print_preview.MeasurementSystem.UnitType.IMPERIAL);
+        ',', '.', print_preview.MeasurementSystemUnitType.IMPERIAL);
 
     /**
      * Collate ticket item.
      * @type {!print_preview.ticket_items.Collate}
      * @private
      */
     this.collate_ = new print_preview.ticket_items.Collate(
         this.appState_, this.destinationStore_);
 
     /**
@@ skipping 145 matching lines @@
     this.tracker_ = new EventTracker();
 
     /**
      * Whether the print preview has been initialized.
      * @type {boolean}
      * @private
      */
     this.isInitialized_ = false;
 
     this.addEventListeners_();
-  };
+  }
 
   /**
    * Event types dispatched by the print ticket store.
    * @enum {string}
    */
   PrintTicketStore.EventType = {
     CAPABILITIES_CHANGE: 'print_preview.PrintTicketStore.CAPABILITIES_CHANGE',
     DOCUMENT_CHANGE: 'print_preview.PrintTicketStore.DOCUMENT_CHANGE',
     INITIALIZE: 'print_preview.PrintTicketStore.INITIALIZE',
     TICKET_CHANGE: 'print_preview.PrintTicketStore.TICKET_CHANGE'
@@ skipping 83 matching lines @@
      *     local system.
      */
     get measurementSystem() {
       return this.measurementSystem_;
     },
 
     /**
      * Initializes the print ticket store. Dispatches an INITIALIZE event.
      * @param {string} thousandsDelimeter Delimeter of the thousands place.
      * @param {string} decimalDelimeter Delimeter of the decimal point.
-     * @param {!print_preview.MeasurementSystem.UnitType} unitType Type of unit
+     * @param {!print_preview.MeasurementSystemUnitType} unitType Type of unit
      *     of the local measurement system.
      * @param {boolean} selectionOnly Whether only selected content should be
      *     printed.
      */
     init: function(
         thousandsDelimeter, decimalDelimeter, unitType, selectionOnly) {
       this.measurementSystem_.setSystem(thousandsDelimeter, decimalDelimeter,
                                         unitType);
       this.selectionOnly_.updateValue(selectionOnly);
 
       // Initialize ticket with user's previous values.
       if (this.appState_.hasField(
-          print_preview.AppState.Field.IS_COLOR_ENABLED)) {
+          print_preview.AppStateField.IS_COLOR_ENABLED)) {
         this.color_.updateValue(
             /** @type {!Object} */(this.appState_.getField(
-            print_preview.AppState.Field.IS_COLOR_ENABLED)));
+            print_preview.AppStateField.IS_COLOR_ENABLED)));
       }
-      if (this.appState_.hasField(print_preview.AppState.Field.DPI)) {
+      if (this.appState_.hasField(print_preview.AppStateField.DPI)) {
         this.dpi_.updateValue(
             /** @type {!Object} */(this.appState_.getField(
-            print_preview.AppState.Field.DPI)));
+            print_preview.AppStateField.DPI)));
       }
       if (this.appState_.hasField(
-          print_preview.AppState.Field.IS_DUPLEX_ENABLED)) {
+          print_preview.AppStateField.IS_DUPLEX_ENABLED)) {
         this.duplex_.updateValue(
             /** @type {!Object} */(this.appState_.getField(
-            print_preview.AppState.Field.IS_DUPLEX_ENABLED)));
+            print_preview.AppStateField.IS_DUPLEX_ENABLED)));
       }
-      if (this.appState_.hasField(print_preview.AppState.Field.MEDIA_SIZE)) {
+      if (this.appState_.hasField(print_preview.AppStateField.MEDIA_SIZE)) {
         this.mediaSize_.updateValue(
             /** @type {!Object} */(this.appState_.getField(
-            print_preview.AppState.Field.MEDIA_SIZE)));
+            print_preview.AppStateField.MEDIA_SIZE)));
       }
       if (this.appState_.hasField(
-          print_preview.AppState.Field.IS_LANDSCAPE_ENABLED)) {
+          print_preview.AppStateField.IS_LANDSCAPE_ENABLED)) {
         this.landscape_.updateValue(
             /** @type {!Object} */(this.appState_.getField(
-            print_preview.AppState.Field.IS_LANDSCAPE_ENABLED)));
+            print_preview.AppStateField.IS_LANDSCAPE_ENABLED)));
       }
       // Initialize margins after landscape because landscape may reset margins.
-      if (this.appState_.hasField(print_preview.AppState.Field.MARGINS_TYPE)) {
+      if (this.appState_.hasField(print_preview.AppStateField.MARGINS_TYPE)) {
         this.marginsType_.updateValue(
             /** @type {!Object} */(this.appState_.getField(
-            print_preview.AppState.Field.MARGINS_TYPE)));
+            print_preview.AppStateField.MARGINS_TYPE)));
       }
       if (this.appState_.hasField(
-          print_preview.AppState.Field.CUSTOM_MARGINS)) {
+          print_preview.AppStateField.CUSTOM_MARGINS)) {
         this.customMargins_.updateValue(
             /** @type {!Object} */(this.appState_.getField(
-            print_preview.AppState.Field.CUSTOM_MARGINS)));
+            print_preview.AppStateField.CUSTOM_MARGINS)));
       }
       if (this.appState_.hasField(
-          print_preview.AppState.Field.IS_HEADER_FOOTER_ENABLED)) {
+          print_preview.AppStateField.IS_HEADER_FOOTER_ENABLED)) {
         this.headerFooter_.updateValue(
             /** @type {!Object} */(this.appState_.getField(
-            print_preview.AppState.Field.IS_HEADER_FOOTER_ENABLED)));
+            print_preview.AppStateField.IS_HEADER_FOOTER_ENABLED)));
       }
       if (this.appState_.hasField(
-          print_preview.AppState.Field.IS_COLLATE_ENABLED)) {
+          print_preview.AppStateField.IS_COLLATE_ENABLED)) {
         this.collate_.updateValue(
             /** @type {!Object} */(this.appState_.getField(
-            print_preview.AppState.Field.IS_COLLATE_ENABLED)));
+            print_preview.AppStateField.IS_COLLATE_ENABLED)));
       }
       if (this.appState_.hasField(
-          print_preview.AppState.Field.IS_FIT_TO_PAGE_ENABLED)) {
+          print_preview.AppStateField.IS_FIT_TO_PAGE_ENABLED)) {
         this.fitToPage_.updateValue(
             /** @type {!Object} */(this.appState_.getField(
-            print_preview.AppState.Field.IS_FIT_TO_PAGE_ENABLED)));
+            print_preview.AppStateField.IS_FIT_TO_PAGE_ENABLED)));
       }
       if (this.appState_.hasField(
-          print_preview.AppState.Field.SCALING)) {
+          print_preview.AppStateField.SCALING)) {
         this.scaling_.updateValue(
             /** @type {!Object} */(this.appState_.getField(
-            print_preview.AppState.Field.SCALING)));
+            print_preview.AppStateField.SCALING)));
       }
       if (this.appState_.hasField(
-          print_preview.AppState.Field.IS_CSS_BACKGROUND_ENABLED)) {
+          print_preview.AppStateField.IS_CSS_BACKGROUND_ENABLED)) {
         this.cssBackground_.updateValue(
             /** @type {!Object} */(this.appState_.getField(
-            print_preview.AppState.Field.IS_CSS_BACKGROUND_ENABLED)));
+            print_preview.AppStateField.IS_CSS_BACKGROUND_ENABLED)));
       }
       if (this.appState_.hasField(
-          print_preview.AppState.Field.VENDOR_OPTIONS)) {
+          print_preview.AppStateField.VENDOR_OPTIONS)) {
         this.vendorItems_.updateValue(
             /** @type {!Object<string>} */(this.appState_.getField(
-            print_preview.AppState.Field.VENDOR_OPTIONS)));
-    }
+            print_preview.AppStateField.VENDOR_OPTIONS)));
+      }
     },
 
     /**
      * @return {boolean} {@code true} if the stored print ticket is valid,
      *     {@code false} otherwise.
      */
     isTicketValid: function() {
       return this.isTicketValidForPreview() &&
           (!this.copies_.isCapabilityAvailable() || this.copies_.isValid()) &&
           (!this.pageRange_.isCapabilityAvailable() ||
               this.pageRange_.isValid());
     },
 
     /** @return {boolean} Whether the ticket is valid for preview generation. */
     isTicketValidForPreview: function() {
       return (!this.marginsType_.isCapabilityAvailable() ||
               !this.marginsType_.isValueEqual(
                   print_preview.ticket_items.MarginsTypeValue.CUSTOM) ||
               this.customMargins_.isValid());
     },
 
     /**
      * Creates an object that represents a Google Cloud Print print ticket.
      * @param {!print_preview.Destination} destination Destination to print to.
-     * @return {!Object} Google Cloud Print print ticket.
+     * @return {!string} Google Cloud Print print ticket.

[dpapad, 2017/05/05 17:32:50]

Nit: "!" is implied for strings (same for number and boolean), therefore can be
removed.

[rbpotter, 2017/05/05 18:25:46]

Done.

      */
     createPrintTicket: function(destination) {
       assert(!destination.isLocal ||
              destination.isPrivet || destination.isExtension,
              'Trying to create a Google Cloud Print print ticket for a local ' +
                  ' non-privet and non-extension destination');
 
       assert(destination.capabilities,
              'Trying to create a Google Cloud Print print ticket for a ' +
                  'destination with no print capabilities');
@@ skipping 138 matching lines @@
     onDocumentInfoChange_: function() {
       cr.dispatchSimpleEvent(this, PrintTicketStore.EventType.DOCUMENT_CHANGE);
     },
   };
 
   // Export
   return {
     PrintTicketStore: PrintTicketStore
   };
 });