Add a command-line option to enable VP9 encoding.

Add a command-line option to enable VP9 encoding.

This is useful for testing. VP9 is already enabled at the client.

BUG=260879
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272050

[Sergey Ulanov, 2014-05-16 23:25:10]

https://codereview.chromium.org/286213006/diff/1/remoting/host/chromoting_hos...
File remoting/host/chromoting_host.cc (right):

https://codereview.chromium.org/286213006/diff/1/remoting/host/chromoting_hos...
remoting/host/chromoting_host.cc:95:
CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
Can we also read this option from the config file? Then it will be possible to
enable it from the webapp when the host is registered..

https://codereview.chromium.org/286213006/diff/1/remoting/host/chromoting_hos...
remoting/host/chromoting_host.cc:97: if (vp9_enabled !=
kEnableVp9SwitchYesValue) {
Chrome normally uses --enable-foo and --disable-foo to enable/disable a feature
instead of --enable-foo=[yes|no].

[Wez, 2014-05-20 20:33:22]

Address review comment

[Wez, 2014-05-20 20:33:48]

https://codereview.chromium.org/286213006/diff/1/remoting/host/chromoting_hos...
File remoting/host/chromoting_host.cc (right):

https://codereview.chromium.org/286213006/diff/1/remoting/host/chromoting_hos...
remoting/host/chromoting_host.cc:95:
CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
On 2014/05/16 23:25:10, Sergey Ulanov wrote:
> Can we also read this option from the config file? Then it will be possible to
> enable it from the webapp when the host is registered..

Yes, but the current CandidateSessionConfig design makes it a little messy, so
I'll send follow-up CLs to enable that.

https://codereview.chromium.org/286213006/diff/1/remoting/host/chromoting_hos...
remoting/host/chromoting_host.cc:97: if (vp9_enabled !=
kEnableVp9SwitchYesValue) {
On 2014/05/16 23:25:10, Sergey Ulanov wrote:
> Chrome normally uses --enable-foo and --disable-foo to enable/disable a
feature
> instead of --enable-foo=[yes|no]. 

Done.

[Sergey Ulanov, 2014-05-21 03:26:46]

lgtm

[Wez, 2014-05-21 03:33:54]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2014-05-21 03:34:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wez@chromium.org/286213006/20001

[commit-bot: I haz the power, 2014-05-21 20:02:48]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-22 02:51:20]

Change committed as 272050