Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 286213004: Update content_webkit_unit_test_support dependency (Closed)

Created:
6 years, 7 months ago by enne (OOO)
Modified:
6 years, 7 months ago
Reviewers:
adamk, ojan
CC:
blink-reviews
Visibility:
Public.

Description

Update content_webkit_unit_test_support dependency This is a followup to https://codereview.chromium.org/287043002/ where content_webkit_unit_test_support got collapsed into test_support_content_target. This is the only include of that target. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174906

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : s/_target// #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/web/web_tests.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
enne (OOO)
6 years, 7 months ago (2014-05-15 22:24:17 UTC) #1
ojan
lgtm
6 years, 7 months ago (2014-05-15 23:34:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/286213004/1
6 years, 7 months ago (2014-05-15 23:34:39 UTC) #3
enne (OOO)
The CQ bit was unchecked by enne@chromium.org
6 years, 7 months ago (2014-05-15 23:35:33 UTC) #4
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 7 months ago (2014-05-21 19:24:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/286213004/1
6 years, 7 months ago (2014-05-21 19:27:18 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 16:30:19 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 16:37:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/8144)
6 years, 7 months ago (2014-05-22 16:37:34 UTC) #9
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 7 months ago (2014-05-27 19:05:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/286213004/20001
6 years, 7 months ago (2014-05-27 19:05:49 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 7 months ago (2014-05-27 20:21:43 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 20:27:38 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/7331) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9151)
6 years, 7 months ago (2014-05-27 20:27:39 UTC) #14
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 7 months ago (2014-05-27 20:44:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/286213004/40001
6 years, 7 months ago (2014-05-27 20:44:49 UTC) #16
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 22:43:38 UTC) #17
Message was sent while issue was closed.
Change committed as 174906

Powered by Google App Engine
This is Rietveld 408576698