Linux Aura: Use incognito profile to theme incognito browser windows

chrome/browser/ui/views/native_widget_factory.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/native_widget_factory.h"
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/views/theme_profile_key.h"
 #include "ui/aura/window.h"
 #include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
@@ skipping 24 matching lines @@
         new views::NativeWidgetAura(delegate);
     if (params->parent) {
       Profile* parent_profile = reinterpret_cast<Profile*>(
           params->parent->GetNativeWindowProperty(Profile::kProfileKey));
       native_widget_aura->SetNativeWindowProperty(Profile::kProfileKey,
                                                   parent_profile);
     }
     window = native_widget_aura->GetNativeWindow();
     native_widget = native_widget_aura;
   }
-  SetThemeProfileForWindow(window, profile);
+  // Use the original profile because |window| may outlive the profile
+  // of the context window.  This can happen with incognito profiles.
+  // However, the original profile will stick around until shutdown.
+  SetThemeProfileForWindow(window, profile->GetOriginalProfile());

[sky, 2017/05/04 23:24:09]

I think it's worth a comment that BrowserView resets the value for browser
windows to profile_.

[Tom (Use chromium acct), 2017/05/09 05:12:26]

Done.

   return native_widget;
 }