Linux Aura: Use incognito profile to theme incognito browser windows

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 2068 matching lines @@
 
 void BrowserView::InitViews() {
   GetWidget()->AddObserver(this);
 
   // Stow a pointer to this object onto the window handle so that we can get at
   // it later when all we have is a native view.
   GetWidget()->SetNativeWindowProperty(kBrowserViewKey, this);
 
   // Stow a pointer to the browser's profile onto the window handle so that we
   // can get it later when all we have is a native view.
   GetWidget()->SetNativeWindowProperty(Profile::kProfileKey,

[sky, 2017/05/04 23:24:09]

Could you instead use kProfileKey now? By that I mean remove 2092-2096 and
change native_widget_factory.cc to do the same?

[Tom (Use chromium acct), 2017/05/04 23:41:46]

Can we just make this change:

- Profile* GetThemeProfileForWindow(aura::Window* window) {
-   return window->GetProperty(kThemeProfileKey);
- }
+ Profile* GetThemeProfileForWindow(aura::Window* window) {
+   Profile* profile = window->GetProperty(kThemeProfileKey);
+   return profile ? profile : window->GetProperty(kProfileKey);
+ }

chrome_browser_main_extra_parts_views_linux.cc would need to change too if we
removed SetThemeProfileForWindow() here

[sky, 2017/05/08 21:44:37]

Could you clarify why we need both kThemeProfileKey and kProfileKey? Under what
conditions do they differ?

[Tom (Use chromium acct), 2017/05/09 05:12:26]

Nevermind, I see what you mean now.  I think we can just use kProfileKey only.

                                        browser_->profile());
 
 #if defined(USE_AURA)
-  // Stow a pointer to the browser's original profile onto the window handle so
+  // Stow a pointer to the browser's profile onto the window handle so
   // that windows will be styled with the appropriate NativeTheme.
-  SetThemeProfileForWindow(GetNativeWindow(),
-                           browser_->profile()->GetOriginalProfile());
+  SetThemeProfileForWindow(GetNativeWindow(), browser_->profile());
 #endif
 
   LoadAccelerators();
 
   contents_web_view_ = new ContentsWebView(browser_->profile());
   contents_web_view_->set_id(VIEW_ID_TAB_CONTAINER);
   contents_web_view_->SetEmbedFullscreenWidgetMode(true);
 
   web_contents_close_handler_.reset(
       new WebContentsCloseHandler(contents_web_view_));
@@ skipping 588 matching lines @@
 }
 
 extensions::ActiveTabPermissionGranter*
 BrowserView::GetActiveTabPermissionGranter() {
   content::WebContents* web_contents = GetActiveWebContents();
   if (!web_contents)
     return nullptr;
   return extensions::TabHelper::FromWebContents(web_contents)
       ->active_tab_permission_granter();
 }