Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: tracing/tracing/metrics/v8/runtime_stats_metric_test.html

Issue 2862103002: Fix main frame detection in loading metrics. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/metrics/system_health/power_metric_test.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/v8/runtime_stats_metric_test.html
diff --git a/tracing/tracing/metrics/v8/runtime_stats_metric_test.html b/tracing/tracing/metrics/v8/runtime_stats_metric_test.html
index 972517f60c0b9c83835ec689960cf874bc6da61b..046ea2488c78ca59f27434d012a500107303818d 100644
--- a/tracing/tracing/metrics/v8/runtime_stats_metric_test.html
+++ b/tracing/tracing/metrics/v8/runtime_stats_metric_test.html
@@ -60,6 +60,13 @@ tr.b.unittest.testSuite(function() {
rendererProcess.objects.addSnapshot('ptr', 'loading', 'FrameLoader', 300,
{isLoadingMainFrame: true, frame: {id_ref: '0xdeadbeef'},
documentLoaderURL: 'http://example.com'});
+ mainThread.sliceGroup.pushSlice(tr.c.TestUtils.newSliceEx({
+ cat: 'loading',
+ title: 'markAsMainFrame',
+ start: 300,
+ duration: 0.0,
+ args: {frame: '0xdeadbeef'}
+ }));
mainThread.sliceGroup.pushSlice(tr.c.TestUtils.newSliceEx({
cat: 'v8',
« no previous file with comments | « tracing/tracing/metrics/system_health/power_metric_test.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698