tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html - Issue 2862103002: Fix main frame detection in loading metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html

Issue 2862103002: Fix main frame detection in loading metrics. (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/extras/chrome/estimated_input_latency_test.html ('k') | tracing/tracing/metrics/system_health/loading_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html

diff --git a/tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html b/tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html

index 9548fe9ad9f0b2b671dc47068922843a60a78c85..e6951335edeb545ce6d4c957193da30f0f5a93f5 100644

--- a/tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html

+++ b/tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html

@@ -27,6 +27,13 @@ tr.b.unittest.testSuite(function() {

frame: {id_ref: '0xdeadbeef'},

documentLoaderURL: 'http://example.com'

});

+ mainThread.sliceGroup.pushSlice(tr.c.TestUtils.newSliceEx({

+ cat: 'loading',

+ title: 'markAsMainFrame',

+ start: timestamp,

+ duration: 0.0,

+ args: {frame: '0xdeadbeef'}

+ }));

mainThread.sliceGroup.pushSlice(tr.c.TestUtils.newSliceEx({

cat: 'loading',

title: 'firstMeaningfulPaintCandidate',