[Isolates] Move more statics (part IV)

[Isolates] Move more statics (part IV)

stub-cache*.cc, stub-cache.h, (serialize.cc)
-> key_reference/value_reference moved into StubCache
-> primary_/secondary_ became instance members of StubCache

spaces.cc/spaces.h
-> comments_statistics

string-stream.cc
-> debug_object_cache
-> current_security_token

regexp-macro-assembler.cc
-> canonicalize
* is word_character_map[] used as a constant?

scopes.cc
* note about Allocator (it might benefit from taking an isolate pointer)



Committed: http://code.google.com/p/v8/source/detail?r=4979

[zarko, 2010-06-28 17:30:56]

Thanks
  Luke

[Vitaly Repeshko, 2010-06-29 17:20:57]

LGTM

http://codereview.chromium.org/2862032/diff/1/5
File src/regexp-macro-assembler.cc (right):

http://codereview.chromium.org/2862032/diff/1/5#newcode188
src/regexp-macro-assembler.cc:188: // TODO(isolates): Verify that this is used
as a constant.
It's only used in load operations. Please add "const" and consider the todo
done.

http://codereview.chromium.org/2862032/diff/1/9
File src/spaces.h (right):

http://codereview.chromium.org/2862032/diff/1/9#newcode2216
src/spaces.h:2216: // must be small, since an iteration is used for lookup
nit: "Must" and full stop at the end.