Test WordGranularity expansion in VisibleSelection.

Test WordGranularity expansion in VisibleSelection.

BUG=None

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174416

[mlamouri (slow - plz ping), 2014-05-16 14:04:51]

This is implementing the tests requested in
https://codereview.chromium.org/267563003/

[jochen (gone - plz use gerrit), 2014-05-16 14:41:22]

Test file missing?
On May 16, 2014 4:04 PM, <mlamouri@chromium.org> wrote:

> Reviewers: jochen,
>
> Message:
> This is implementing the tests requested in
> https://codereview.chromium.org/267563003/
>
> Description:
> Test WordGranularity expansion in VisibleSelection.
>
> BUG=None
>
> Please review this at https://codereview.chromium.org/286203012/
>
> SVN Base: https://chromium.googlesource.com/chromium/blink.git@master
>
> Affected files (+2, -0 lines):
>   M Source/core/core.gypi
>   M Source/core/editing/VisibleSelection.h
>
>
> Index: Source/core/core.gypi
> diff --git a/Source/core/core.gypi b/Source/core/core.gypi
> index 133dc1710a2768724fd8bc016a1df11838499e15..
> df1157b8c7165e274326dad599d553dade2b0c30 100644
> --- a/Source/core/core.gypi
> +++ b/Source/core/core.gypi
> @@ -3375,6 +3375,7 @@
>              'dom/RangeTest.cpp',
>              'dom/TreeScopeTest.cpp',
>              'editing/TextIteratorTest.cpp',
> +            'editing/VisibleSelectionTest.cpp',
>              'fetch/CachingCorrectnessTest.cpp',
>              'fetch/ImageResourceTest.cpp',
>              'fetch/MemoryCacheTest.cpp',
> Index: Source/core/editing/VisibleSelection.h
> diff --git a/Source/core/editing/VisibleSelection.h b/Source/core/editing/
> VisibleSelection.h
> index c14630c15d700258279bc14bf5c7d10716c4e681..
> 445506bc3d49d18502557bfcd6cb8744b9e24e24 100644
> --- a/Source/core/editing/VisibleSelection.h
> +++ b/Source/core/editing/VisibleSelection.h
> @@ -39,6 +39,7 @@ const EAffinity SEL_DEFAULT_AFFINITY = DOWNSTREAM;
>  enum SelectionDirection { DirectionForward, DirectionBackward,
> DirectionRight, DirectionLeft };
>
>  class VisibleSelection {
> +    friend class VisibleSelectionTest;
>  public:
>      VisibleSelection();
>
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[mlamouri (slow - plz ping), 2014-05-16 14:57:25]

Oups... :) Should be there now.

[jochen (gone - plz use gerrit), 2014-05-19 13:24:07]

lgtm

https://codereview.chromium.org/286203012/diff/50001/Source/core/editing/Visi...
File Source/core/editing/VisibleSelectionTest.cpp (right):

https://codereview.chromium.org/286203012/diff/50001/Source/core/editing/Visi...
Source/core/editing/VisibleSelectionTest.cpp:2: // // Use of this source code is
governed by a BSD-style license that can be
incorrect header

[mlamouri (slow - plz ping), 2014-05-20 20:17:14]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-05-20 20:17:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/286203012/70001

[commit-bot: I haz the power, 2014-05-20 21:47:32]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/5775)

[commit-bot: I haz the power, 2014-05-20 22:04:39]

Change committed as 174416