Harden builtins BuildResultFromMatchInfo and URIDecodeOctets

Harden builtins BuildResultFromMatchInfo and URIDecodeOctets

R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21343

[Jakob Kummerow, 2014-05-16 13:27:12]

PTAL.

[Yang, 2014-05-16 13:39:09]

lgtm.

https://codereview.chromium.org/286203010/diff/1/src/regexp.js
File src/regexp.js (right):

https://codereview.chromium.org/286203010/diff/1/src/regexp.js#newcode114
src/regexp.js:114: macro BuildResultFromMatchInfo(MATCHINFO, STRING)
I would use capital naming for the macro to make it clear at call sites that
it's a macro.

https://codereview.chromium.org/286203010/diff/1/src/regexp.js#newcode138
src/regexp.js:138: return result;
Why not make this part of the macro and call it something like
RETURN_NEW_RESULT_FROM_MATCH_INFO.

[Jakob Kummerow, 2014-05-16 13:43:04]

https://codereview.chromium.org/286203010/diff/1/src/regexp.js
File src/regexp.js (right):

https://codereview.chromium.org/286203010/diff/1/src/regexp.js#newcode114
src/regexp.js:114: macro BuildResultFromMatchInfo(MATCHINFO, STRING)
On 2014/05/16 13:39:09, Yang wrote:
> I would use capital naming for the macro to make it clear at call sites that
> it's a macro.

Done.

https://codereview.chromium.org/286203010/diff/1/src/regexp.js#newcode138
src/regexp.js:138: return result;
On 2014/05/16 13:39:09, Yang wrote:
> Why not make this part of the macro and call it something like
> RETURN_NEW_RESULT_FROM_MATCH_INFO.

Done.

[Jakob Kummerow, 2014-05-16 13:43:26]

Committed patchset #2 manually as r21343 (presubmit successful).