Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 286203008: Revert of Stop ServiceWorker context when no controllee is associated (and when all refs are dropped) (Closed)

Created:
6 years, 7 months ago by Adrian Kuegel
Modified:
6 years, 7 months ago
Reviewers:
michaeln, kinuko, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org, Jeffrey Yasskin
Visibility:
Public.

Description

Revert of Stop ServiceWorker context when no controllee is associated (and when all refs are dropped) (https://codereview.chromium.org/272183005/) Reason for revert: Has memory leaks in EmbeddedWorkerInstanceTest.InstanceDestroyedBeforeStartFinishes Original issue's description: > Stop ServiceWorker context when no controllee is associated (and when all refs are dropped) > > Currently we stop the ServiceWorker thread/context when: > 1. After all documents that are controlled by the SW are closed, with a delay (5 min) > 2. All references to the version are dropped (i.e. in dtor) > > In the current impl/codebase a worker is immediately stopped by 2 > in most cases. > > The same stop timer (ScheduleStopWorker()) could be probably called > each time handling event is finished to stop the worker more > aggressively, though this patch doesn't do so. > > BUG=372673 > TEST=tested manually with chrome://serviceworker-internals/ > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270971 TBR=michaeln@chromium.org,horo@chromium.org,kinuko@chromium.org NOTREECHECKS=true NOTRY=true BUG=372673 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -52 lines) Patch
M content/browser/service_worker/embedded_worker_instance.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 4 chunks +3 lines, -16 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 4 chunks +1 line, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 9 chunks +7 lines, -27 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Adrian Kuegel
6 years, 7 months ago (2014-05-16 09:52:37 UTC) #1
Created Revert of Stop ServiceWorker context when no controllee is associated
(and when all refs are dropped)

Powered by Google App Engine
This is Rietveld 408576698