Issue 286203004: Cast: Log target encode bitrate before a frame is encoded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 286203004: Cast: Log target encode bitrate before a frame is encoded. (Closed)

Created:
6 years, 7 months ago by imcheng

Modified:
6 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Cast: Log target encode bitrate before a frame is encoded. Read the target encode bitrate and bind it to the "encoded" callback before actually encode the frame instead of reading the target bitrate after frame has been encoded . This gives a more accurate value of the encode bitrate each frame was encoded at. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271132

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	media/cast/video_sender/video_sender.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	media/cast/video_sender/video_sender.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/286203004/1

6 years, 7 months ago (2014-05-16 18:16:23 UTC) #3

Message was sent while issue was closed.

Change committed as 271132

Expand Messages | Collapse Messages