Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 286203003: Whitelist chrome.screenlockPrivate only for component apps on ChromeOS. (Closed)

Created:
6 years, 7 months ago by Ilya Sherman
Modified:
6 years, 5 months ago
Reviewers:
Yoyo Zhou, Tim Song
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Whitelist chrome.screenlockPrivate only for component apps on ChromeOS. One Windows and Mac, continue to use a whitelist of app ids. BUG=353449 TEST=none R=tengs@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281690

Patch Set 1 #

Patch Set 2 : Fix unittests: whitelist test extensions while testing. #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase and add a missing header #

Patch Set 6 : Fix compile errors due to namespacing #

Patch Set 7 : Rebase #

Patch Set 8 : Fix compile after rebase #

Patch Set 9 : Enable the API on Linux as well #

Patch Set 10 : Run tests as component extension tests on ChromeOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc View 1 2 3 4 5 6 7 8 9 4 chunks +18 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 3 4 5 6 7 8 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 45 (0 generated)
Ilya Sherman
6 years, 7 months ago (2014-05-15 23:43:42 UTC) #1
Tim Song
LGTM
6 years, 7 months ago (2014-05-16 00:38:20 UTC) #2
Ilya Sherman
+Yoyo for OWNERS approval. (We decided to not worry about the flag for now, as ...
6 years, 7 months ago (2014-05-16 03:21:48 UTC) #3
Yoyo Zhou
LGTM
6 years, 7 months ago (2014-05-16 06:25:34 UTC) #4
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-16 07:09:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/286203003/1
6 years, 7 months ago (2014-05-16 07:09:14 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 08:48:32 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 09:48:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/27753)
6 years, 7 months ago (2014-05-16 09:48:26 UTC) #9
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-16 21:34:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/286203003/20001
6 years, 7 months ago (2014-05-16 23:32:14 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 05:40:16 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-17 05:45:07 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68238) linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/28077) linux_chromium_clang_dbg ...
6 years, 7 months ago (2014-05-17 05:45:08 UTC) #14
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-17 21:44:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/286203003/40001
6 years, 7 months ago (2014-05-17 21:45:04 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 23:32:55 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-18 00:23:42 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/28205)
6 years, 7 months ago (2014-05-18 00:23:42 UTC) #19
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 6 months ago (2014-05-29 23:05:22 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/286203003/50001
6 years, 6 months ago (2014-05-29 23:06:58 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 03:53:20 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 04:32:50 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/21797)
6 years, 6 months ago (2014-05-30 04:32:50 UTC) #24
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 6 months ago (2014-06-04 23:12:48 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/286203003/70001
6 years, 6 months ago (2014-06-04 23:14:42 UTC) #26
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 04:51:03 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 05:22:22 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/24198)
6 years, 6 months ago (2014-06-05 05:22:22 UTC) #29
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 6 months ago (2014-06-06 05:15:19 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/286203003/90001
6 years, 6 months ago (2014-06-06 05:17:02 UTC) #31
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 10:02:47 UTC) #32
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 11:07:20 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/39204)
6 years, 6 months ago (2014-06-06 11:07:21 UTC) #34
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-02 22:32:00 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/286203003/130001
6 years, 5 months ago (2014-07-02 22:33:00 UTC) #36
Ilya Sherman
The CQ bit was unchecked by isherman@chromium.org
6 years, 5 months ago (2014-07-03 01:40:58 UTC) #37
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-03 01:54:12 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/286203003/150001
6 years, 5 months ago (2014-07-03 01:56:37 UTC) #39
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-03 06:47:19 UTC) #40
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-03 08:08:57 UTC) #41
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/44282)
6 years, 5 months ago (2014-07-03 08:08:58 UTC) #42
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-08 06:12:29 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/286203003/170001
6 years, 5 months ago (2014-07-08 06:13:33 UTC) #44
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 07:31:26 UTC) #45
Message was sent while issue was closed.
Change committed as 281690

Powered by Google App Engine
This is Rietveld 408576698