Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: chrome/browser/chromeos/policy/user_network_configuration_updater_factory.cc

Issue 2862003002: Enable policy-imported root CA certificates for kiosk and AD sessions (Closed)
Patch Set: Addressed comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/user_network_configuration_updater_factory.cc
diff --git a/chrome/browser/chromeos/policy/user_network_configuration_updater_factory.cc b/chrome/browser/chromeos/policy/user_network_configuration_updater_factory.cc
index e13ed617a4b8da8a2fe01406cc2e16205422294b..6ea318b4eb64f3a1b397830b107b35b7513788b4 100644
--- a/chrome/browser/chromeos/policy/user_network_configuration_updater_factory.cc
+++ b/chrome/browser/chromeos/policy/user_network_configuration_updater_factory.cc
@@ -72,18 +72,27 @@ KeyedService* UserNetworkConfigurationUpdaterFactory::BuildServiceInstanceFor(
if (user != user_manager::UserManager::Get()->GetPrimaryUser())
return NULL;
- const bool allow_trusted_certs_from_policy = user->HasGaiaAccount();
-
ProfilePolicyConnector* profile_connector =
ProfilePolicyConnectorFactory::GetForBrowserContext(context);
return UserNetworkConfigurationUpdater::CreateForUserPolicy(
- profile,
- allow_trusted_certs_from_policy,
- *user,
- profile_connector->policy_service(),
- chromeos::NetworkHandler::Get()->managed_network_configuration_handler())
+ profile, AllowTrustedCertsFromPolicy(user), *user,
+ profile_connector->policy_service(),
+ chromeos::NetworkHandler::Get()
+ ->managed_network_configuration_handler())
.release();
}
+// static
+bool UserNetworkConfigurationUpdaterFactory::AllowTrustedCertsFromPolicy(
+ const user_manager::User* user) {
+ user_manager::UserType user_type = user->GetType();
+
+ // Disallow trusted root certs for public sessions.
+ // Also, guest sessions don't get user policy, but a
+ // UserNetworkCofnigurationUpdater can be created for them anyway.
+ return user_type != user_manager::USER_TYPE_GUEST &&
+ user_type != user_manager::USER_TYPE_PUBLIC_ACCOUNT;
+}
+
} // namespace policy

Powered by Google App Engine
This is Rietveld 408576698