[ignition] Optimize JSGenerator creation

src/interpreter/interpreter-assembler.cc

Index: src/interpreter/interpreter-assembler.cc
diff --git a/src/interpreter/interpreter-assembler.cc b/src/interpreter/interpreter-assembler.cc
index b65c7c7501a45466081797fde5fb3e3df869f200..217fdc6a3b27e972b0ac447d125e0062a75b1e10 100644
--- a/src/interpreter/interpreter-assembler.cc
+++ b/src/interpreter/interpreter-assembler.cc
@@ -748,7 +748,8 @@ Node* InterpreterAssembler::CallJS(Node* function, Node* context,
                                    ConvertReceiverMode receiver_mode,
                                    TailCallMode tail_call_mode) {
   DCHECK(Bytecodes::MakesCallAlongCriticalPath(bytecode_));
-  DCHECK(Bytecodes::IsCallOrConstruct(bytecode_));
+  DCHECK(Bytecodes::IsCallOrConstruct(bytecode_) ||
+         bytecode_ == Bytecode::kInvokeIntrinsic);

[rmcilroy, 2017/05/05 09:44:11]

please also remove this, InvokeIntrinsic shouldn't be calling a JS function.

[mvstanton, 2017/05/05 11:50:26]

Drat, it does so, in this call stack in bytecode handler generation:


#2  v8::internal::interpreter::InterpreterAssembler::CallJS ()
    at ../../src/interpreter/interpreter-assembler.cc:751
#3  v8::internal::interpreter::IntrinsicsGenerator::Call ()
    at ../../src/interpreter/interpreter-intrinsics-generator.cc:311
#4  v8::internal::interpreter::IntrinsicsGenerator::InvokeIntrinsic () 
    at ../../src/interpreter/interpreter-intrinsics-generator.cc:98
#5  v8::internal::interpreter::GenerateInvokeIntrinsic () 
    at ../../src/interpreter/interpreter-intrinsics-generator.cc:63
#6  v8::internal::interpreter::InvokeIntrinsicAssembler::GenerateImpl () 
    at ../../src/interpreter/interpreter-generator.cc:1997
#7  v8::internal::interpreter::InvokeIntrinsicAssembler::Generate ()
    at ../../src/interpreter/interpreter-generator.cc:1992
#8  v8::internal::interpreter::GenerateBytecodeHandler ()
    ...

The bytecode_ is kInvokeIntrinsic. It looks like in the act of generating the
bytecode handler to invoke an intrinsic we run into this. A bootstrapping
problem? That's why I allowed the exception -- perhaps there is another way?

[rmcilroy, 2017/05/05 13:50:32]

Ahh yeah, I forgot we had the Runtime::kInlineCall intrinsic which performs a JS
call to another function.  Yeah we should add this to allow Intrinsic to CallJS
in that case, thanks for checking.

   DCHECK_EQ(Bytecodes::GetReceiverMode(bytecode_), receiver_mode);
   Callable callable = CodeFactory::InterpreterPushArgsThenCall(
       isolate(), receiver_mode, tail_call_mode,