[ignition] Optimize JSGenerator creation

src/interpreter/bytecodes.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_INTERPRETER_BYTECODES_H_
 #define V8_INTERPRETER_BYTECODES_H_
 
 #include <cstdint>
 #include <iosfwd>
 #include <string>
@@ skipping 622 matching lines @@
            bytecode == Bytecode::kCallProperty1 ||
            bytecode == Bytecode::kCallProperty2 ||
            bytecode == Bytecode::kCallUndefinedReceiver ||
            bytecode == Bytecode::kCallUndefinedReceiver0 ||
            bytecode == Bytecode::kCallUndefinedReceiver1 ||
            bytecode == Bytecode::kCallUndefinedReceiver2 ||
            bytecode == Bytecode::kTailCall ||
            bytecode == Bytecode::kConstruct ||
            bytecode == Bytecode::kCallWithSpread ||
            bytecode == Bytecode::kConstructWithSpread ||
-           bytecode == Bytecode::kInvokeIntrinsic ||
            bytecode == Bytecode::kCallJSRuntime;
   }
 
   // Returns true if the bytecode is a call to the runtime.
   static constexpr bool IsCallRuntime(Bytecode bytecode) {
     return bytecode == Bytecode::kCallRuntime ||
            bytecode == Bytecode::kCallRuntimeForPair ||
            bytecode == Bytecode::kInvokeIntrinsic;
   }
 
@@ skipping 91 matching lines @@
 
   // Returns the equivalent jump bytecode without the accumulator coercion.
   static Bytecode GetJumpWithoutToBoolean(Bytecode bytecode);
 
   // Returns true if there is a call in the most-frequently executed path
   // through the bytecode's handler.
   static bool MakesCallAlongCriticalPath(Bytecode bytecode);
 
   // Returns the receiver mode of the given call bytecode.
   static ConvertReceiverMode GetReceiverMode(Bytecode bytecode) {
-    DCHECK(IsCallOrConstruct(bytecode));
+    DCHECK(IsCallOrConstruct(bytecode) ||
+           bytecode == Bytecode::kInvokeIntrinsic);

[rmcilroy, 2017/05/05 09:44:11]

please remove this and the kInvokeIntrinsic in the switch below, we shouldn't be
calling this with Bytecode::kInvokeIntrinic

[mvstanton, 2017/05/05 11:50:26]

This is a side-effect of the location identified with your other comment. The
Call() code wants to get the receiver mode, and therefore I weaken this assert
in the same way.

[rmcilroy, 2017/05/05 13:50:32]

Right, makes sense, thanks for checking.

     switch (bytecode) {
       case Bytecode::kCallProperty:
       case Bytecode::kCallProperty0:
       case Bytecode::kCallProperty1:
       case Bytecode::kCallProperty2:
         return ConvertReceiverMode::kNotNullOrUndefined;
       case Bytecode::kCallUndefinedReceiver:
       case Bytecode::kCallUndefinedReceiver0:
       case Bytecode::kCallUndefinedReceiver1:
       case Bytecode::kCallUndefinedReceiver2:
@@ skipping 112 matching lines @@
 };
 
 V8_EXPORT_PRIVATE std::ostream& operator<<(std::ostream& os,
                                            const Bytecode& bytecode);
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_INTERPRETER_BYTECODES_H_