[CrOS Tether] Transform NetworkConnectionHandler to an interface.

chromeos/network/network_connection_handler_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_connection_handler.h"
 
 #include <map>
 #include <memory>
 #include <set>
 
@@ skipping 134 matching lines @@
 
     network_profile_handler_.reset(new NetworkProfileHandler());
     network_profile_handler_->Init();
 
     managed_config_handler_.reset(new ManagedNetworkConfigurationHandlerImpl());
     managed_config_handler_->Init(
         network_state_handler(), network_profile_handler_.get(),
         network_config_handler_.get(), nullptr /* network_device_handler */,
         nullptr /* prohibited_tecnologies_handler */);
 
-    network_connection_handler_.reset(new NetworkConnectionHandler);
+    network_connection_handler_ = NetworkConnectionHandler::Create();

[stevenjb, 2017/05/03 22:05:38]

new NetworkConnectionHandlerImpl(), just like we do for
ManagedNetworkConfigurationHandlerImpl above.

[Kyle Horimoto, 2017/05/03 22:38:30]

Done.

     network_connection_handler_->Init(network_state_handler(),
                                       network_config_handler_.get(),
                                       managed_config_handler_.get());
     network_connection_observer_.reset(new TestNetworkConnectionObserver);
     network_connection_handler_->AddObserver(
         network_connection_observer_.get());
 
     base::RunLoop().RunUntilIdle();
 
     fake_tether_delegate_.reset(new FakeTetherDelegate());
@@ skipping 368 matching lines @@
   EXPECT_EQ(
       NetworkConnectionHandler::kErrorTetherConnectionAttemptWithNoDelegate,
       GetResultAndReset());
   EXPECT_TRUE(network_connection_observer_->GetRequested(kTetherGuid));
   EXPECT_EQ(
       NetworkConnectionHandler::kErrorTetherConnectionAttemptWithNoDelegate,
       network_connection_observer_->GetResult(kTetherGuid));
 }
 
 }  // namespace chromeos