[CrOS Tether] Transform NetworkConnectionHandler to an interface.

chromeos/components/tether/initializer_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/components/tether/initializer.h"
 
 #include <memory>
 
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 71 matching lines @@
                void(const std::string&, const base::DictionaryValue&, bool));
   MOCK_METHOD2(CreateConfigurationAndConnect,
                void(base::DictionaryValue*, bool));
   MOCK_METHOD2(CreateConfiguration, void(base::DictionaryValue*, bool));
 };
 
 class TestNetworkConnectionHandler : public NetworkConnectionHandler {
  public:
   TestNetworkConnectionHandler() : NetworkConnectionHandler() {}
   ~TestNetworkConnectionHandler() override {}
+
+  // NetworkConnectionHandler:
+  void ConnectToNetwork(const std::string& service_path,
+                        const base::Closure& success_callback,
+                        const network_handler::ErrorCallback& error_callback,
+                        bool check_error_state) override {}

[stevenjb, 2017/05/03 22:05:38]

blank line between methods with an implementation. (inline accessors / setters
can be exempted, e.g. set_foo(int foo) { foo_ = foo}).

[Kyle Horimoto, 2017/05/03 22:38:29]

Done.

+  void DisconnectNetwork(
+      const std::string& service_path,
+      const base::Closure& success_callback,
+      const network_handler::ErrorCallback& error_callback) override {}
+  bool HasConnectingNetwork(const std::string& service_path) override {
+    return false;
+  }
+  bool HasPendingConnectRequest() override { return false; }
+  void Init(NetworkStateHandler* network_state_handler,
+            NetworkConfigurationHandler* network_configuration_handler,
+            ManagedNetworkConfigurationHandler*
+                managed_network_configuration_handler) override {}
+
+  // LoginState::Observer
+  void LoggedInStateChanged() override {}
+
+  // CertLoader::Observer
+  void OnCertificatesLoaded(const net::CertificateList& cert_list,
+                            bool initial_load) override {}
 };
 
 }  // namespace
 
 class InitializerTest : public NetworkStateTest {
  protected:
   InitializerTest() : NetworkStateTest() {}
   ~InitializerTest() override {}
 
   void SetUp() override {
@@ skipping 88 matching lines @@
       fake_cryptauth_service.get(),
       base::MakeUnique<FakeNotificationPresenter>(), test_pref_service_.get(),
       fake_token_service.get(), network_state_handler(),
       managed_network_configuration_handler.get(), mock_network_connect.get(),
       network_connection_handler_.get(), mock_adapter);
 }
 
 }  // namespace tether
 
 }  // namespace chromeos