ui/views/controls/menu/menu_types.h - Issue 2861873002: Align the base of the shelf's context menu to the top edge of the shelf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_types.h

Issue 2861873002: Align the base of the shelf's context menu to the top edge of the shelf. (Closed)

Patch Set: Align the base of the shelf's context menu to the top edge of the shelf. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_types.h

diff --git a/ui/views/controls/menu/menu_types.h b/ui/views/controls/menu/menu_types.h

index 160dd5ae3d1f9c5b4a9e3304511234f1931dc909..a54fa53d5ef67cd4890e9728674d09f25237d403 100644

--- a/ui/views/controls/menu/menu_types.h

+++ b/ui/views/controls/menu/menu_types.h

@@ -15,6 +15,8 @@ enum MenuAnchorPosition {

MENU_ANCHOR_TOPLEFT,

MENU_ANCHOR_TOPRIGHT,

MENU_ANCHOR_BOTTOMCENTER,

+ MENU_ANCHOR_FIXED_BOTTOMCENTER,

msw 2017/05/10 22:18:23 nit: describe these in the enum comment.

+ MENU_ANCHOR_SIDECENTER,

msw 2017/05/10 22:18:23 nit: should this be |MENU_ANCHOR_FIXED_SIDECENTER|

MENU_ANCHOR_BUBBLE_LEFT,

MENU_ANCHOR_BUBBLE_RIGHT,

MENU_ANCHOR_BUBBLE_ABOVE,