ui/views/controls/menu/menu_runner.cc - Issue 2861873002: Align the base of the shelf's context menu to the top edge of the shelf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_runner.cc

Issue 2861873002: Align the base of the shelf's context menu to the top edge of the shelf. (Closed)

Patch Set: nits. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_runner.cc

diff --git a/ui/views/controls/menu/menu_runner.cc b/ui/views/controls/menu/menu_runner.cc

index 991f76bc48a89261a695e03da2ee81a803758506..bd16bfc34fe7370942a08dea933dab7570105de4 100644

--- a/ui/views/controls/menu/menu_runner.cc

+++ b/ui/views/controls/menu/menu_runner.cc

@@ -53,7 +53,7 @@ void MenuRunner::RunMenuAt(Widget* parent,

internal::DisplayChangeListener::Create(parent, this));

}

- if (run_types_ & CONTEXT_MENU) {

+ if ((run_types_ & CONTEXT_MENU) && !(run_types_ & FIXED_ANCHOR)) {

switch (source_type) {

case ui::MENU_SOURCE_NONE:

case ui::MENU_SOURCE_KEYBOARD:

« no previous file with comments | « ui/views/controls/menu/menu_runner.h ('k') | ui/views/controls/menu/menu_types.h » ('j') | no next file with comments »