components/offline_items_collection/core/android/offline_item_bridge.cc - Issue 2861863002: offline_items_collection : Added helper class to determine progress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_items_collection/core/android/offline_item_bridge.cc

Issue 2861863002: offline_items_collection : Added helper class to determine progress (Closed)

Patch Set: findbugs Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java ('K') | « components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/bridges/OfflineItemBridge.java ('k') | components/offline_items_collection/core/offline_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_items_collection/core/android/offline_item_bridge.cc

diff --git a/components/offline_items_collection/core/android/offline_item_bridge.cc b/components/offline_items_collection/core/android/offline_item_bridge.cc

index a21c50c5343268455511bd40a78029d3b3e0cd9b..e44697cdbc31d24ac83acd49194edc9c4172dcf5 100644

--- a/components/offline_items_collection/core/android/offline_item_bridge.cc

+++ b/components/offline_items_collection/core/android/offline_item_bridge.cc

@@ -37,7 +37,8 @@ ScopedJavaLocalRef<jobject> createOfflineItemAndMaybeAddToList(

ConvertUTF8ToJavaString(env, item.page_url.spec()),

ConvertUTF8ToJavaString(env, item.original_url.spec()),

item.is_off_the_record, static_cast<jint>(item.state), item.is_resumable,

- item.allow_metered, item.received_bytes, item.percent_completed,

+ item.allow_metered, item.received_bytes, item.progress.value,

+ item.progress.max.value_or(-1), static_cast<int>(item.progress.unit),

David Trainor- moved to gerrit 2017/05/09 05:36:01 int -> jint?

shaktisahu 2017/05/09 19:04:32 Done.

item.time_remaining_ms);

}